feat: Connect Python builder to Rust #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
bjchambers
force-pushed
the
ben/connect-query-builder
branch
from
76237eb
to
3c9a738
Compare
kevinjnguyen
approved these changes
Jul 27, 2023
This creates DFG nodes and checks their types. Some extra features: - Uses the pyarrow types of the expression to limit some overloads. In the case of `__getattr__` this prevents mistakes leading easily to infinite recursion. In the case of `expr[expr]` this lets us use the correct methods. - Allows using python literals (`str`, `int` and `float`) as arguments to expressions. - Renames `ffi` module to `_ffi` to indicate it is private. - Add some tests fro error cases
bjchambers
force-pushed
the
ben/connect-query-builder
branch
from
f099e79
to
b435b8a
Compare
bjchambers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates DFG nodes and checks their types.
Some extra features:
In the case of
__getattr__this prevents mistakes leading easily toinfinite recursion. In the case of
expr[expr]this lets us use thecorrect methods.
str,intandfloat) as argumentsto expressions.
ffimodule to_ffito indicate it is private.