Final reindex algorithm #1430
Merged
Final reindex algorithm #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts to use it (instead of exact comparisons)
…d as argument and fixed an important related bug
Codecov Report
@@ Coverage Diff @@
## v0.9.0-dev #1430 +/- ##
==================================
==================================
Continue to review full report at Codecov.
|
svarogg
reviewed
Jan 20, 2021
domain/consensus/processes/reachabilitymanager/reindex_stretch_test.go
Outdated
Show resolved
Hide resolved
someone235
requested changes
Jan 20, 2021
domain/consensus/processes/reachabilitymanager/reachability_external_test.go
Outdated
Show resolved
Hide resolved
domain/consensus/processes/reachabilitymanager/reachability_test.go
Outdated
Show resolved
Hide resolved
domain/consensus/processes/reachabilitymanager/reindex_context.go
Outdated
Show resolved
Hide resolved
domain/consensus/processes/reachabilitymanager/reindex_context.go
Outdated
Show resolved
Hide resolved
someone235
previously approved these changes
Jan 21, 2021
someone235
requested changes
Jan 26, 2021
domain/consensus/processes/reachabilitymanager/reachability_stretch_test.go
Outdated
Show resolved
Hide resolved
domain/consensus/processes/reachabilitymanager/reachability_stretch_test.go
Outdated
Show resolved
Hide resolved
domain/consensus/processes/reachabilitymanager/reachability_stretch_test.go
Outdated
Show resolved
Hide resolved
someone235
previously approved these changes
Jan 26, 2021
someone235
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a deep fixup to the reachability reindex algorithm to make it suitable and resilient for attack scenarios. The new implementation uses reindex slacks in an improved way, such that large side chains are handled efficiently as well -- by a double-the-size allocation mechanism. The PR also includes reindex stretch tests, which use json baseline DAGs and add arbitrary blocks all over the DAG in a fuzzy manner.