Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ban when sending pruned blocks #1530

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

someone235
Copy link
Collaborator

On handshake an out of date node sends its selected tip, which can be below the pruning point. We don't want to ban such behaviour.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #1530 (8b68df2) into v0.9.0-dev (e78cdff) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v0.9.0-dev    #1530      +/-   ##
==============================================
+ Coverage       61.78%   61.80%   +0.02%     
==============================================
  Files             507      507              
  Lines           19247    19250       +3     
==============================================
+ Hits            11892    11898       +6     
+ Misses           5648     5646       -2     
+ Partials         1707     1706       -1     
Impacted Files Coverage Δ
app/protocol/flows/blockrelay/handle_relay_invs.go 69.93% <0.00%> (+1.26%) ⬆️
infrastructure/network/netadapter/router/route.go 85.71% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e78cdff...fbe3ad4. Read the comment docs.

@stasatdaglabs stasatdaglabs merged commit 2908a46 into v0.9.0-dev Feb 15, 2021
@stasatdaglabs stasatdaglabs deleted the dont-ban-when-sending-pruned-blocks branch February 15, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants