-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fee estimation to wallet #2291
Merged
michaelsutton
merged 32 commits into
kaspanet:master
from
someone235:add-wallet-fee-estimation
Oct 22, 2024
Merged
Add fee estimation to wallet #2291
michaelsutton
merged 32 commits into
kaspanet:master
from
someone235:add-wallet-fee-estimation
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someone235
force-pushed
the
add-wallet-fee-estimation
branch
from
September 4, 2024 11:54
0c449a9
to
78ca616
Compare
someone235
force-pushed
the
add-wallet-fee-estimation
branch
from
September 4, 2024 12:55
57b9c52
to
1203403
Compare
someone235
force-pushed
the
add-wallet-fee-estimation
branch
from
September 4, 2024 12:58
1203403
to
c582d29
Compare
someone235
force-pushed
the
add-wallet-fee-estimation
branch
from
September 5, 2024 07:16
c582d29
to
93726ef
Compare
someone235
force-pushed
the
add-wallet-fee-estimation
branch
from
September 11, 2024 11:31
02ead24
to
2385971
Compare
michaelsutton
force-pushed
the
add-wallet-fee-estimation
branch
from
September 11, 2024 12:49
0f00163
to
fda5557
Compare
someone235
force-pushed
the
add-wallet-fee-estimation
branch
from
September 13, 2024 10:49
470b9c7
to
8153ec7
Compare
…e235/kaspad into add-wallet-fee-estimation
michaelsutton
force-pushed
the
add-wallet-fee-estimation
branch
from
September 15, 2024 09:31
cebb0b0
to
d7a7902
Compare
someone235
force-pushed
the
add-wallet-fee-estimation
branch
from
September 15, 2024 14:55
d573ca1
to
9e659b2
Compare
someone235
force-pushed
the
add-wallet-fee-estimation
branch
from
September 16, 2024 10:34
2c01f22
to
e8058e2
Compare
someone235
force-pushed
the
add-wallet-fee-estimation
branch
from
September 16, 2024 10:35
e8058e2
to
484c17e
Compare
someone235
force-pushed
the
add-wallet-fee-estimation
branch
from
September 18, 2024 11:41
9fce3c8
to
16a68ba
Compare
someone235
force-pushed
the
add-wallet-fee-estimation
branch
from
September 18, 2024 11:44
16a68ba
to
707b3a1
Compare
michaelsutton
approved these changes
Oct 22, 2024
TMKCodes
pushed a commit
to Hoosat-Oy/HTND
that referenced
this pull request
Oct 30, 2024
* Add fee estimation to wallet * Add fee rate to kaspawallet parse * Update go version * Get rid of golint * Add RBF support to wallet * Fix bump_fee UTXO lookup and fix wrong change address * impl storage mass as per KIP9 * Use CalculateTransactionOverallMass where needed * Some fixes * Minor typos * Fix test * update version * BroadcastRBF -> BroadcastReplacement * rc3 * align proto files to only use camel case (fixed on RK as well) * Rename to FeePolicy and add MaxFee option + todo * apply max fee constrains * increase minChangeTarget to 10kas * fmt * Some fixes * fix description: maximum -> minimum * put min feerate check in the correct location * Fix calculateFeeLimits nil handling * Add validations to CLI flags * Change to rc6 * Add checkTransactionFeeRate * Add failed broadcast transactions on send error` * Fix estimateFee change value * Estimate fee correctly for --send-all * On estimateFee always assume that the recipient has ECDSA address * remove patch version --------- Co-authored-by: Michael Sutton <msutton@cs.huji.ac.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.