Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preprocessing fails when $SHELL is fish. #88

Closed
bobthecow opened this issue Apr 29, 2016 · 4 comments
Closed

Preprocessing fails when $SHELL is fish. #88

bobthecow opened this issue Apr 29, 2016 · 4 comments
Assignees
@kasper
Labels
bug
Milestone
2.1.1

Comments

@bobthecow
Copy link

bobthecow commented Apr 29, 2016 •
edited by kasper
Loading

  • Version: 2.1
  • OS X: 10.11.4

When my $SHELL is set to fish, $PATH is exported as space delimited here, but bash expects it to be colon delimited here. Can we use the same shell in both places so preprocessing works?

Thanks! 😄
@kasper
Copy link
Owner

kasper commented Apr 29, 2016

Damn! Good catch, I will release an update today. 😃

@kasper kasper added the bug label Apr 29, 2016
@kasper kasper added this to the 2.1.1 milestone Apr 29, 2016
@kasper kasper self-assigned this Apr 29, 2016
@bobthecow
Copy link
Author

Great, thanks!

kasper added a commit that referenced this issue Apr 29, 2016
@kasper
Fix an issue that prevented preprocessing due to incompatible paths b…
a72f854 
…etween different shells (#88)
@kasper
Copy link
Owner

kasper commented Apr 29, 2016

@bobthecow Thanks for the short and detailed explanation! This is now fixed and 2.1.1 has been released. It should sort things out.

@kasper kasper closed this as completed Apr 29, 2016
@bobthecow
Copy link
Author

Thanks for the quick response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasper kasper

Labels
bug
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
2 participants
@bobthecow @kasper