Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debug capabilities in the Safari context by listing of configuration file(s) in the developer tools sidebar #265

Merged
merged 2 commits into from
Nov 28, 2020

Conversation

varp
Copy link
Contributor

@varp varp commented Oct 21, 2020

  • Updated related documentations
  • Added the change to the Changelog

@kasper
Copy link
Owner

kasper commented Oct 21, 2020

Oh, nice one! Will review and test this once I have time.

@mafredri
Copy link
Contributor

mafredri commented Oct 30, 2020

@varp, super nice! I had to make some tweaks to my typescript config (uses webpack) to get the sourcemaps included, but after that, worked perfectly. I did have to use the Debug build of Phoenix though, when I build it with Release settings it doesn't show up as a JSContext in Safari.

@kasper
Copy link
Owner

kasper commented Oct 31, 2020

@mafredri Yes, unfortunately Apple has restricted this.

@kasper kasper self-assigned this Nov 28, 2020
@kasper kasper added this to the 2.6.5 milestone Nov 28, 2020
@kasper kasper merged commit 9225bb8 into kasper:master Nov 28, 2020
@kasper
Copy link
Owner

kasper commented Nov 28, 2020

Thank you! Seems to work nicely!

kasper added a commit that referenced this pull request Nov 28, 2020
@varp
Copy link
Contributor Author

varp commented Nov 28, 2020

Was glad to be a part ) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants