use zig package manager (requires master) #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! Thanks for the contribution. Need to change CI/CD zig version. |
kassane
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Change it
qml_zig/.github/workflows/Linux.yml
Lines 13 to 15 in 64b6869
qml_zig/.github/workflows/MSYS.yml
Lines 23 to 26 in 64b6869
|
Fixed |
|
Awesome contribution! However, I'll wait for this issue in DOtherSide to be fixed. You can see in the CI that clang gives an error. |
* dotherside fix: filcuc/dotherside#119 (comment) * new minimum version: zig v0.12.0
|
Wait: https://github.com/ziglang/zig/milestone/23 (v0.12.0) |
kassane
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zig package manager now allows you to use the package manager for non-zig projects, which is perfect in this case.