Skip to content

Commit

Permalink
Enable flag disableModulePatternComponents for native-fb (facebook#27807
Browse files Browse the repository at this point in the history
)

facebook#27742 will remove this feature flag altogether, this just already
removes the dynamic flag for the Meta React Native build ahead of time.
  • Loading branch information
kassens authored Dec 6, 2023
1 parent 9cae442 commit be8aa76
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import typeof * as DynamicFlagsType from 'ReactNativeInternalFeatureFlags';
// update the test configuration.

export const alwaysThrottleRetries = __VARIANT__;
export const disableModulePatternComponents = __VARIANT__;
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
export const enableUnifiedSyncLane = __VARIANT__;
export const enableUseRefAccessWarning = __VARIANT__;
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/forks/ReactFeatureFlags.native-fb.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import * as dynamicFlags from 'ReactNativeInternalFeatureFlags';
// the exports object every time a flag is read.
export const {
alwaysThrottleRetries,
disableModulePatternComponents,
enableDeferRootSchedulingToMicrotask,
enableUnifiedSyncLane,
enableUseRefAccessWarning,
Expand All @@ -28,6 +27,7 @@ export const {
} = dynamicFlags;

// The rest of the flags are static for better dead code elimination.
export const disableModulePatternComponents = true;
export const enableDebugTracing = false;
export const enableSchedulingProfiler = __PROFILE__;
export const enableProfilerTimer = __PROFILE__;
Expand Down
1 change: 0 additions & 1 deletion scripts/flow/xplat.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

declare module 'ReactNativeInternalFeatureFlags' {
declare export var alwaysThrottleRetries: boolean;
declare export var disableModulePatternComponents: boolean;
declare export var enableDeferRootSchedulingToMicrotask: boolean;
declare export var enableUnifiedSyncLane: boolean;
declare export var enableUseRefAccessWarning: boolean;
Expand Down

0 comments on commit be8aa76

Please sign in to comment.