This repository has been archived by the owner on May 12, 2021. It is now read-only.
Don't shutdown the VM when agents terminates #449
Comments
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this issue
Jan 30, 2019
The semantic around the agent is that it should be a passive component, hence it should not implicitly shut down the VM. Instead, we expect the kata-runtime to be responsible for this, using the appropriate VM interface to stop it. Fixes kata-containers#449 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this issue
Jan 30, 2019
The semantic around the agent is that it should be a passive component, hence it should not implicitly shut down the VM. Instead, we expect the kata-runtime to be responsible for this, using the appropriate VM interface to stop it. Fixes kata-containers#449 Depends-on: github.com/kata-containers/tests#1101 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this issue
Jan 30, 2019
The semantic around the agent is that it should be a passive component, hence it should not implicitly shut down the VM. Instead, we expect the kata-runtime to be responsible for this, using the appropriate VM interface to stop it. Fixes kata-containers#449 Depends-on: github.com/kata-containers/tests#1101 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
jodh-intel
pushed a commit
to jodh-intel/agent-1
that referenced
this issue
Feb 25, 2019
The semantic around the agent is that it should be a passive component, hence it should not implicitly shut down the VM. Instead, we expect the kata-runtime to be responsible for this, using the appropriate VM interface to stop it. Fixes kata-containers#449 Depends-on: github.com/kata-containers/tests#1101 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
jodh-intel
pushed a commit
to jodh-intel/agent-1
that referenced
this issue
Mar 8, 2019
The semantic around the agent is that it should be a passive component, hence it should not implicitly shut down the VM. Instead, we expect the kata-runtime to be responsible for this, using the appropriate VM interface to stop it. Fixes kata-containers#449 Depends-on: github.com/kata-containers/tests#1101 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
jodh-intel
pushed a commit
to jodh-intel/agent-1
that referenced
this issue
Mar 8, 2019
The semantic around the agent is that it should be a passive component, hence it should not implicitly shut down the VM. Instead, we expect the kata-runtime to be responsible for this, using the appropriate VM interface to stop it. Fixes kata-containers#449 Depends-on: github.com/kata-containers/tests#1101 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com> Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
egernst
pushed a commit
to egernst/agent-1
that referenced
this issue
Apr 16, 2019
The semantic around the agent is that it should be a passive component, hence it should not implicitly shut down the VM. Instead, we expect the kata-runtime to be responsible for this, using the appropriate VM interface to stop it. Fixes kata-containers#449 Depends-on: github.com/kata-containers/tests#1101 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com> Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I was looking into the kata systemd service file and I realized we are still powering off the VM when the agent returns. Because we expect the VM to be stopped by the runtime in every case, we cannot afford to have the agent powering off the VM, and I think the following lines should be removed: https://github.com/kata-containers/agent/blob/master/kata-agent.service.in#L13-L14
/cc @jcvenegas @devimc @mcastelino
The text was updated successfully, but these errors were encountered: