This repository has been archived by the owner on May 12, 2021. It is now read-only.
Limitation: Document docker --security-opt option not supported #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @nitkon! lgtm |
|
lgtm |
|
ping @kata-containers/documentation |
|
lgtm.
|
|
Good point @caoruidong! @nitkon - could you reword this change slightly because although we don't support the following security options (yet):
... we do support:
Hence, it might be best to say we only partially support |
Fixes: #241 Signed-off-by: Nitesh Konkar niteshkonkar@in.ibm.com
|
@jcvenegas @jodh-intel : Updated my PR. |
|
lgtm. @klynnrif - ptal.
|
|
looks good, and it is not a big patch. let's merge it. |
devimc
pushed a commit
to devimc/kata-documentation
that referenced
this pull request
Sep 2, 2019
build and install kata containers components from master and run osbuilder tests. fixes kata-containers#242 Signed-off-by: Julio Montes <julio.montes@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #241
Signed-off-by: Nitesh Konkar niteshkonkar@in.ibm.com