Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard: Add single PR view #31

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

dashboard: Add single PR view #31

wants to merge 3 commits into from
+1,403 −399

Conversation

afinn12
Copy link
Contributor

@afinn12 afinn12 commented Nov 18, 2024 •
edited
Loading

Needed

Description

image

After selecting a PR:

image

  • The display (and PR number) is appended to the URL, so specific views can be shared/reloaded
  • The result is the latest result if the check was rerun
  • Total runs is for the given PR number
    • The rowExpansionTemplate still shows the results across all 10 PRs, could change to add different information here.

Testing

  • Tested in dev
  • Tested in prod
    • Used data from our forked repo instead since data hasn't been updated in this repo yet

@afinn12
dashboard: Add view for PR runs
d2ba40b 
Added a script that fetches PR data and created a separate view on the dashboard.

Fixes kata-containers#1

Signed-off-by: Anna Finn <afinn12@bu.edu>
@afinn12
dashboard: Indicate if a test was rerun
70fdee2 
Added code to get rerun information to both fetch scripts.
Display the reruns as a superscript in the rowExpansionTemplate with the result/URL.

Fixes: kata-containers#8

Signed-off-by: Anna Finn <afinn12@bu.edu>
@afinn12
dashboard: Add single PR view
508c992 
Added a separate view to display all tests for a given PR.
Added the display to the URL, rowExpansionTemplate is unchanged.

Fixes: kata-containers#12

Signed-off-by: Anna Finn <afinn12@bu.edu>
@afinn12 afinn12 marked this pull request as ready for review November 18, 2024 22:21
a1icja
a1icja reviewed Nov 18, 2024
View reviewed changes
.github/workflows/fectch-ci-data.yml
Comment on lines -22 to -24
# Use bash to fail fast:
# https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell
shell: bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely keep this to prevent false workflow passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a1icja a1icja a1icja left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afinn12 @a1icja