kernel: enable kvm_ptp for arm64 #693
Conversation
|
LGTM @jongwu have you considered move this to kernel fragments, I think it would be easier to maintainer, what do you think? |
|
@devimc I am now working on that, but I don't know if or when the patch can be accept by linux kernel side. IMO before kvm ptp supported by kernel, we can using this experimental one for arm64 temporarily. WDYT? |
|
@devimc by the way, even though kvm ptp for arm64 supported by kernel later, it takes long for kata to move kernel to that version. |
|
@jongwu ok, sounds good |
|
/test |
|
snap often unhappy |
|
Restarted snap CI which failed with a network timeout. |
|
Gah - there is no /retest |
|
@jcvenegas, @chavafg - how do I start the |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
maybe we can try obs ci again @devimc thanks |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| @@ -0,0 +1,421 @@ | |||
| From e9a740c5cf801acd4446325e45d90b54b0ce5e6d Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
@jongwu Have you submitted this patch upstream? If so, can you include a link in the commit message?
Does the host kernel need to be patched as well to support the hypercall?
There was a problem hiding this comment.
@amshinde yeah, I have pushed this patch to upstream. but my patch base on v5.3, so it can't be patched into v4.19. this commit is largely different with the one in upstream.
To enable ptp_kvm on arm64, a patch needed for host, but I don't know where can I put it.
the patch in upstream can be a hint. I will link it in commit message.
| static int ptp_kvm_adjfreq(struct ptp_clock_info *ptp, s32 ppb) | ||
| { | ||
| - return -EOPNOTSUPP; | ||
| + return -EOPNOTSUPP; |
There was a problem hiding this comment.
Is this and the below few changes required. Seem like just format changes.
There was a problem hiding this comment.
let me refine it @amshinde thanks.
jongwu
force-pushed
the
ptp
branch
2 times, most recently
from
b12e5c2
to
6e108e5
Compare
|
@jongwu shall we run the CI again? |
|
@jcvenegas yeah, thanks |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Looks like Jenkins is stuck. /test-ubuntu |
|
/test-snap |
|
/test-ubuntu-snap |
|
@devimc - could you update https://github.com/kata-containers/community/wiki/Controlling-the-CI with the magic to restart the snap job? |
|
@jodh-intel there is no magic to restart the snap CI, I don't know why it's stuck 😟 |
|
/test |
|
hmm, I think packaging jobs were not updated for @jongwu can you please update the |
This is a experimental feature for arm64 as linux kernel has not enable kvm ptp for arm64. ptp_kvm need co-work from host and guest, so you need add this patch both to your guest and host. Host kernel version is better lower than 5.0 and higher than 4.19. another version of this patch base on kernel v5.3 is under review in kernel upstream, refer to [1] to see the full info. [1] https://lkml.org/lkml/2019/8/29/80 Fixes: kata-containers#692 Signed-off-by: Jianyong Wu jianyong.wu@arm.com
|
/test |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This is a experimental feature for arm64 as linux kernel has
not enable kvm ptp for arm64.
ptp_kvm need co-work from host and guest, so you need add this
patch both to your guest and host. Host kernel version is better
lower than 5.0 and higher than 4.19.
another version of this patch base on kernel v5.3 is under review in kernel upstream, refer to [1]
to see the full info.
[1] https://lkml.org/lkml/2019/8/29/80
Fixes: #692
Signed-off-by: Jianyong Wu jianyong.wu@arm.com
@jodh-intel @grahamwhaley @Pennyzct