Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

cli go test failures #1508

Closed
bergwolf opened this issue Apr 9, 2019 · 0 comments · Fixed by #1509
Closed

cli go test failures #1508

bergwolf opened this issue Apr 9, 2019 · 0 comments · Fixed by #1509

Comments

@bergwolf
Copy link
Member

bergwolf commented Apr 9, 2019

We don't really require nested nor unrestricted_guest to run. And there is no point validating host cpu properties in UT.

INFO[0002] kernel property found                         arch=amd64 container=1 description="Intel KVM" name=kvm_intel pid=15098 sandbox=99999999-9999-
9999-99999999999999999 source=runtime type=module
WARN[0002] kernel module parameter has unexpected value  arch=amd64 container=1 description="Intel KVM" expected=Y name=kvm_intel parameter=nested pid=
15098 sandbox=99999999-9999-9999-99999999999999999 source=runtime type=module value=N
INFO[0002] Kernel property value correct                 arch=amd64 container=1 description="Intel KVM" expected=Y name=kvm_intel parameter=unrestricte
d_guest pid=15098 sandbox=99999999-9999-9999-99999999999999999 source=runtime type=module value=Y
--- FAIL: TestCheckCheckKernelModulesNoNesting (0.00s)
        Error Trace:    kata-check_amd64_test.go:220
        Error:          Should NOT be empty, but was []

ERRO[0001] kernel module parameter has unexpected value  arch=amd64 description="Intel KVM" expected=Y name=kvm_intel parameter=unrestricted_guest pid=16345 source=runtime type=module value=N
INFO[0001] Kernel property value correct                 arch=amd64 description="Intel KVM" expected=Y name=kvm_intel parameter=unrestricted_guest pid=16345 source=runtime type=module value=N
--- FAIL: TestCheckCheckKernelModulesNoUnrestrictedGuest (0.00s)
        Error Trace:    kata-check_amd64_test.go:314
        Error:          Should NOT be empty, but was []
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Apr 9, 2019
@bergwolf
cli: fix kata-check test
4675192 
We don't really require nested nor unrestricted_guest to run. And there
is no point validating host cpu properties in UT.

Fixes: kata-containers#1508

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
@bergwolf bergwolf mentioned this issue Apr 9, 2019
Merged
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Apr 10, 2019
@bergwolf
cli: fix kata-check test
9ac6831 
We don't really require nested nor unrestricted_guest to run. And there
is no point validating host cpu properties in UT.

Fixes: kata-containers#1508

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
egernst pushed a commit to egernst/runtime that referenced this issue Apr 16, 2019
@bergwolf
cli: fix kata-check test
0baa56b 
We don't really require nested nor unrestricted_guest to run. And there
is no point validating host cpu properties in UT.

Fixes: kata-containers#1508

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-runtime that referenced this issue Apr 16, 2019
@lifupan
cli: Merge pull request kata-containers#1509 from bergwolf/kata-check
0b7c329 
cli: fix kata-check test
(cherry picked from commit da08b3a)

Fixes: kata-containers#1508

Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
egernst pushed a commit to egernst/runtime that referenced this issue Apr 17, 2019
@bergwolf
cli: fix kata-check test
8874e25 
We don't really require nested nor unrestricted_guest to run. And there
is no point validating host cpu properties in UT.

Fixes: kata-containers#1508

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: fix kata-check test bergwolf/kata-runtime
1 participant
@bergwolf