This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: add support for loading kernel modules #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devimc
added
do-not-merge
|
waiting for kata-containers/agent#616 |
devimc
force-pushed
the
topic/virtcontainers/loadKernelModules
branch
from
6b174a7
to
9a41ff6
Compare
jodh-intel
approved these changes
Aug 2, 2019
| # - kernel_modules=["e1000e InterruptThrottleRate=3000,3000,3000 EEE=1", "i915 enable_ppgtt=0"] | ||
| # The first word is considered as the module name and the rest as its parameters. | ||
| # | ||
| kernel_modules=[] |
There was a problem hiding this comment.
This obviously relies on the admin specifying a set of modules that is going to be available in the guests kernel. As such, I think it is worth stating here what happens if:
- the module is not available in the guest kernel.
modprobedisabled in the guest environment.- the module is architecture-specific and the guest is running an incompatible architecture.
devimc
force-pushed
the
topic/virtcontainers/loadKernelModules
branch
from
9a41ff6
to
68c9ae3
Compare
|
@jodh-intel change applied, thanks |
devimc
removed
do-not-merge
devimc
force-pushed
the
topic/virtcontainers/loadKernelModules
branch
3 times, most recently
from
466e487
to
279e4cc
Compare
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #1926 +/- ##
=========================================
Coverage ? 52.18%
=========================================
Files ? 108
Lines ? 14224
Branches ? 0
=========================================
Hits ? 7423
Misses ? 5921
Partials ? 880 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1926 +/- ##
=========================================
Coverage ? 52.18%
=========================================
Files ? 108
Lines ? 14224
Branches ? 0
=========================================
Hits ? 7423
Misses ? 5921
Partials ? 880 |
added 2 commits
August 6, 2019 20:55
Bring support for loading kernel modules shortlog: 72a50ef revert: agent: sandbox_pause should get arguments from proc ad72fe8 agent: add support for loading kernel modules 4ab32a9 vendor: dep check fixes b8b8dac s390x: add virtio-blk-ccw support cf20c9b ci: Allow travis to use go install script 5ffb2a6 agent: make NoPivotRoot config depend on `/` fs type a1c9d50 make: install depends on $(TARGET) 7c97a0a agent: delete element of sandbox.deviceWatchers with right key d0117bf release: Kata Containers 1.9.0-alpha0 4354b24 tests: Add lots of new unit tests d4a22d1 device: Allow uevent handler to be stopped 8eb2134 config: Add parseCmdlineOption test d4f205d device: Add extra checks faa6cb0 mount: Fix incorrect error return 2d95c36 mount: Add test for parseMountFlagsAndOptions 5163bab console: Add debug console test d167490 sandbox: Remove redundant check 72fc0ad mount: Improve error message c92715f tests: Add test for getMemory cd2f994 memory: Add extra check for memory file 458b4aa vendor: Move to a previous version for runtime-spec vendor 3cce728 vendor: Update the vendoring for github.com/opencontainers/runtime-spec 7ae6030 release: Kata Containers 1.8.0-rc0 32428bc vendor: update dependency opencontainers/runc cfbd8c9 agent: sandbox_pause should get arguments from proc 47476d4 agent: lock subreaper agent thread 3548e65 release: Kata Containers 1.8.0-alpha2 0ead592 docs: Fix capitalization 9b59925 mount: Virtio-blk container rootfs mount for ACRN hypervisor cf50209 release: Kata Containers 1.8.0-alpha1 0666ef0 release: Kata Containers 1.8.0-alpha0 ca2f724 grpc: add unit test for onlineResources function 06a0743 tmp: Add tmp.mount to kata-containers.target 353263d docs: Fix typos and formatting 5064045 docs: Add missing document link c66349b mount: Add a proper rollback path to addStorages() 5583acd release: Kata Containers 1.7.0 5f9df74 updateInterface: enable hot-add nic on arm64 86ca8e0 vendor: update gogo/protobuf to v1.2.1 c9343fb release: Kata Containers 1.7.0-rc1 560dc87 vendor: update vsock package version 0af7173 agent: support debug console d9aa453 proto: add network stats 3169c9b docs: Fix markdown in TRACING.md 8aa2880 release: Kata Containers 1.7.0-alpha1 2ada1d1 agent: Display trace details cb32d28 test: Fix mockContainer 3e12793 agent: Fix container creation 6e558f7 vendor: Update libcontainer vendoring 7fbd860 agent: send SIGKILL instead of SIGTERM to container init process 8847998 agent: Add support for local storage 8b34aaf make: Add build option STATIC=1 to statically link 01b1cb2 travis: Use xenial d815c97 lint: Update code to handle lint issues 828b417 ci: Update travis go version from 1.10 to 1.11 f61ca8a release: Kata Containers 1.7.0-alpha0 bdf2290 ci: travis: checkout test repo to correct branch 209aa2f agent: Fix "agent grpc server quits" show wrong error 2af3599 channel: Check for channel type in kernel cmdline options 8187461 vendor: use latest github.com/mdlayher/vsock 39696c0 vendor: Revert "vendor: Update libcontainer vendoring" 7866668 agent: Revert "agent: Fix container creation" 8f893b9 test: Revert "test: Fix mockContainer" 49e5847 systemd-target: Add chronyd.service to kata-containers.target 0bf9d1e make: Install systemd targets in systemd unit dir 85e0942 docs: Explain shutdown behaviour with tracing 99d6118 docs: Define "VM" in tracing doc 353ec2d service: Fix user initiated shutdown with static tracing Signed-off-by: Julio Montes <julio.montes@intel.com>
The list of kernel modules can be passed to the runtime through the configuration file or using OCI annotations. In both cases, a list paramentes can be specified for each module. fixes kata-containers#1925 Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
force-pushed
the
topic/virtcontainers/loadKernelModules
branch
from
279e4cc
to
355b9c0
Compare
|
/test |
1 similar comment
|
/test |
|
the Power8 failure is not related with this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of kernel modules can be passed to the runtime through the
configuration file or using OCI annotations. In both cases, a list paramentes
can be specified for each module.
fixes #1925
Signed-off-by: Julio Montes julio.montes@intel.com