Cleanup template properly #764
Conversation
So that we don't leave it behind. Signed-off-by: Peng Tao <bergwolf@gmail.com>
|
Related to kata-containers/tests#761 |
|
PSS Measurement: Memory inside container: |
So that we do not leave artifacts like template mountpoint behind. Fixes: kata-containers#763 Signed-off-by: Peng Tao <bergwolf@gmail.com>
bergwolf
force-pushed
the
cleanup-template
branch
from
997e55c
to
67ffa2f
Compare
|
PSS Measurement: Memory inside container: |
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=========================================
Coverage ? 65.29%
=========================================
Files ? 87
Lines ? 10570
Branches ? 0
=========================================
Hits ? 6902
Misses ? 2976
Partials ? 692 |
|
lgtm |
|
Travis in snooze mode - I don't see a build over at https://travis-ci.org/kata-containers/runtime/builds I'll spend a few minutes to see if I can see a reason why maybe. |
|
It seems that travis decides I have sent to many build requests to them... I have contacted their support. Until they solve it, travis-ci will continue ignoring my PRs. sigh :( |
|
Wow @bergwolf - that is the strangest 'sign of success' yet - err, congratulations on the many PRs ;-) |
|
congrats @bergwolf; lol |
|
Yup. Lets merge :) |
As CI has found out by running the UTs, we are not cleaning up vm factory properly in error path. Also the UTs need to close factory properly so that we do not leave the template mountpoint behind.