shim: Add option to read and print the logs from the agent

[devimc]

shim is now able to read and print the agent logs, making the
debugging processes easier when use_vsocks is true.

fixes #171

Signed-off-by: Julio Montes julio.montes@intel.com

[devimc]

/test

[grahamwhaley]

lgtm
minor nits
oh, if this works, that'll be great @devimc :-)

[sboeuf]

@devimc this sounds like a nice way to bypass the vsock limitation for agent logs.
But the question is, from a kata-runtime perspective, which shim are you going to pick to listen onto the socket?
My concern is that you will have each container level shim listening onto this socket, while we want only a single entity listening to this (since the agent is considered pod level), right?

[devimc]

@sboeuf

But the question is, from a kata-runtime perspective, which shim are you going to pick to listen onto the socket?

the fist shim (sandbox)

My concern is that you will have each container level shim listening onto this socket, while we want only a single entity listening to this (since the agent is considered pod level), right?

yes, only the sandbox shim is going to listen it, see devimc/kata-runtime@09b5bb9

[devimc]

@grahamwhaley changes applied, thanks

[devimc]

/test

[devimc]

/test

[sboeuf]

@devimc

yes, only the sandbox shim is going to listen it, see devimc/kata-runtime@09b5bb9

Ok this sounds good, but are you sure the ContainerType annotation is going to be provided in case of Docker? This will work for CRI callers (CRI-O, CRI/containerd), but I am worried this will not work for Docker.

[devimc]

@sboeuf it's working on docker and the CI seems happy kata-containers/runtime#1597

[grahamwhaley]

Fedora CI failed - I'll nudge:

state container 
  with workload [true], timeWait 5
  /tmp/jenkins/workspace/kata-containers-shim-fedora-PR/go/src/github.com/kata-containers/tests/vendor/github.com/onsi/ginkgo/extensions/table/table_entry.go:46
Running command '/usr/local/bin/kata-runtime [kata-runtime --log=/tmp/bundle345590837/log run --bundle=/tmp/bundle345590837 --console= --pid-file=/tmp/bundle345590837/pid --detach ahkdkPuqiwbRLh9nfCIU]'
command failed error 'exit status 1'
[kata-runtime --log=/tmp/bundle345590837/log run --bundle=/tmp/bundle345590837 --console= --pid-file=/tmp/bundle345590837/pid --detach ahkdkPuqiwbRLh9nfCIU]
Timeout: 120 seconds
Exit Code: 1
Stdout: 
Stderr: Failed to check if grpc server is working: rpc error: code = Unavailable desc = transport is closing

Running command '/usr/local/bin/kata-runtime [kata-runtime list --quiet]'
[kata-runtime list --quiet]
Timeout: 120 seconds
Exit Code: 0
Stdout: 
Stderr: 

Ignoring Power8 CI for now until I hear it is back to being stable.