Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

agent and runtime cannot pass travis-ci after switch to golangci-lint #1345

Closed
teawater opened this issue Mar 23, 2019 · 2 comments
Closed
Assignees

Comments

@teawater
Copy link
Member

After merge #1315
travis-ci failed in:
kata-containers/runtime#1409
kata-containers/runtime#1410
kata-containers/agent#493

=== CONT  TestSourcesFromTestdataWithIssuesDir/depguard.go
--- FAIL: TestSourcesFromTestdataWithIssuesDir (0.30s)
	linters_test.go:38: testdata/*.go
    --- FAIL: TestSourcesFromTestdataWithIssuesDir/ineffassign.go (0.26s)
    	linters_test.go:137: [run --disable-all --print-issued-lines=false --print-linter-name=false --out-format=line-number -Eineffassign --no-config testdata/ineffassign.go]
    	require.go:794: 
    			Error Trace:	linters_test.go:34
    			            				linters_test.go:138
    			            				linters_test.go:54
    			Error:      	Received unexpected error:
    			            	
    			            	unmatched errors
    			            	2019/03/23 00:41:15 unknown architecture wasm
    			Test:       	TestSourcesFromTestdataWithIssuesDir/ineffassign.go
    --- FAIL: TestSourcesFromTestdataWithIssuesDir/deadcode.go (0.26s)
...
...
@teawater
Copy link
Member Author

Just reproduced the issue in my part.
Upstream golangci-lint cannot pass test with go1.10.8. But OK with go1.12.1.

@teawater
Copy link
Member Author

  golangci-lint:
    description: "utility to run various golang linters"
    url: "github.com/golangci/golangci-lint"
    # Using HEAD for now as v1.15.0 does not compile with golang 1.12+. Will be
    # pegged to the next release once it comes out.
    # https://github.com/kata-containers/tests/issues/1329
    version: "HEAD"

golangci-lint v1.15.0 cannot work with golang 1.12+
golangci-lint HEAD cannot work with go1.10.8

@teawater teawater self-assigned this Mar 23, 2019
teawater added a commit to teawater/tests that referenced this issue Mar 23, 2019
…0883af

Using d278457390d8c314192c08a7024e4648c40883af for now as
v1.15.0 does not compile with golang 1.12+ and HEAD cannot
pass test with golang 1.10.8.
Will be pegged to other version once there is a verion
can work OK with golang 1.12+ and golang 1.10.8.

Fixes: kata-containers#1345

Signed-off-by: Hui Zhu <teawater@hyper.sh>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant