Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

CI does not fail if PR breaks Gopkg and vendor sync #1794

Closed
ganeshmaharaj opened this issue Jul 10, 2019 · 0 comments · Fixed by #1795
Closed

CI does not fail if PR breaks Gopkg and vendor sync #1794

ganeshmaharaj opened this issue Jul 10, 2019 · 0 comments · Fixed by #1795
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@ganeshmaharaj
Copy link

Current CI will check if Gopkg and vendor folder are out of sync but does not fail CI. This in-turn breaks the sync between the two. Just running dep ensure on current master generates a commit like this. kata-containers/runtime@9a346d6

Make sure that sync check is run on all PRs.
@ganeshmaharaj ganeshmaharaj added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jul 10, 2019
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 10, 2019
Check vendor sync
5eef86f 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
@ganeshmaharaj ganeshmaharaj mentioned this issue Jul 10, 2019
Merged
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 10, 2019
ci: Check vendor sync
6a63dca 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 10, 2019
ci: Check vendor sync
7cafcc9 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 10, 2019
vendor: Sync gopkg and vendor
553764e 
Contents that are a result of running `dep ensure` on the repository

Fixes: kata-containers#1794
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 10, 2019
Check vendor sync
53bd227 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 10, 2019
ci: Check vendor sync
a6bb1ab 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 25, 2019
vendor: Unify Gopkg files and vendor folder within the repository
3bcdea1 
This repository contains multiple Gopkg.* files which defines
dependencies for each stand-alone application within this repository.
This was posing an issue where there was no predictable way of
confirming that vendor folder is in sync with the versions defined in
Gopkg files. dep tool does not handle multiple sub folder definitions
and is not a feature that is in their pipeline. This effort is to unify
all the dependencies to allow `dep check` on the repository. Check
golang/dep#985 for dep issues with nesting.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 25, 2019
ci: Check vendor folder sync
adfaab9 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
vendor: Unify Gopkg files and vendor folder within the repository
9a175b9 
This repository contains multiple Gopkg.* files which defines
dependencies for each stand-alone application within this repository.
This was posing an issue where there was no predictable way of
confirming that vendor folder is in sync with the versions defined in
Gopkg files. dep tool does not handle multiple sub folder definitions
and is not a feature that is in their pipeline. This effort is to unify
all the dependencies to allow `dep check` on the repository. Check
golang/dep#985 for dep issues with nesting.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
ci: Check vendor folder sync
bc6202f 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
vendor: Unify Gopkg files and vendor folder within the repository
1c7ef35 
This repository contains multiple Gopkg.* files which defines
dependencies for each stand-alone application within this repository.
This was posing an issue where there was no predictable way of
confirming that vendor folder is in sync with the versions defined in
Gopkg files. dep tool does not handle multiple sub folder definitions
and is not a feature that is in their pipeline. This effort is to unify
all the dependencies to allow `dep check` on the repository. Check
golang/dep#985 for dep issues with nesting.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
ci: Check vendor folder sync
f5f84d8 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
vendor: Unify Gopkg files and vendor folder within the repository
16cc8ab 
This repository contains multiple Gopkg.* files which defines
dependencies for each stand-alone application within this repository.
This was posing an issue where there was no predictable way of
confirming that vendor folder is in sync with the versions defined in
Gopkg files. dep tool does not handle multiple sub folder definitions
and is not a feature that is in their pipeline. This effort is to unify
all the dependencies to allow `dep check` on the repository. Check
golang/dep#985 for dep issues with nesting.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
ci: Check vendor folder sync
ba270c9 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
vendor: Unify Gopkg files and vendor folder within the repository
6e5f72a 
This repository contains multiple Gopkg.* files which defines
dependencies for each stand-alone application within this repository.
This was posing an issue where there was no predictable way of
confirming that vendor folder is in sync with the versions defined in
Gopkg files. dep tool does not handle multiple sub folder definitions
and is not a feature that is in their pipeline. This effort is to unify
all the dependencies to allow `dep check` on the repository. Check
golang/dep#985 for dep issues with nesting.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-tests that referenced this issue Jul 26, 2019
ci: Check vendor folder sync
f569f35 
dep ensure -dry-run -no-vendor will check and show if vendor code is out
of sync with GOpkg files but always has a return code of 0. Switching it
to dep check will fail if Gopkg is not in sync with vendor.

Fixes: kata-containers#1794
Fixes: kata-containers#1733
Signed-off-by: Ganesh Maharaj Mahalingam <ganesh.mahalingam@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check vendor sync ganeshmaharaj/kata-tests
1 participant
@ganeshmaharaj