This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 196
Make it clear that new tests should go to the kata-containers
repo
#5718
Open
fidencio
wants to merge
2
commits into
kata-containers:main
Choose a base branch
from
fidencio:topic/make-it-clear-that-new-tests-should-go-to-kata-containers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make it clear that new tests should go to the kata-containers
repo
#5718
fidencio
wants to merge
2
commits into
kata-containers:main
from
fidencio:topic/make-it-clear-that-new-tests-should-go-to-kata-containers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
It's been deprecated for some time already. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Let's make it as explicit as possible that new tests should be developed for the `kata-containers` repo instead of this one. Fixes: kata-containers#5717 Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
fidencio
force-pushed
the
topic/make-it-clear-that-new-tests-should-go-to-kata-containers
branch
from
July 18, 2023 16:00
48de655
to
39eebfb
Compare
/test |
stevenhorsman
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the go get
fix whilst you were in the README
studychao
reviewed
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a simple comment.
And also, do we plan to migrate all tests into Kata main repo (including tests like spelling check, license check)?
@@ -4,10 +4,26 @@ This repository contains various types of tests and utilities (called | |||
"content" from now on) for testing the [Kata Containers](https://github.com/kata-containers) | |||
code repositories. | |||
|
|||
**NOTE:** If you're working on adding new tests to Kata Containers, **please**, | |||
keep in mind that we're in the process of migrating the tests from this repo to | |||
the kata-containers one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a link here would be better?
[Kata Containers](https://github.com/kata-containers)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make it as explicit as possible that new tests should be developed
for the
kata-containers
repo instead of this one.Fixes: #5717