This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
nydus: add var directory cleanup #5788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
fidencio
reviewed
Oct 23, 2023
| @@ -41,6 +41,7 @@ main () { | |||
| sudo systemctl stop "${CRI_RUNTIME}" | |||
|
|
|||
| sudo kill -9 $(pidof "containerd-nydus-grpc") || true | |||
| sudo rm -rf "/var/lib/containerd-nydus" || true | |||
There was a problem hiding this comment.
@ryansavino, as part of the cleanup, I'd also add:
for i in `sudo ctr -n k8s.io snapshot --snapshotter nydus list | grep -v KEY | cut -d' ' -f1`; do sudo ctr -n k8s.io snapshot --snapshotter nydus rm $i; done
There was a problem hiding this comment.
Thanks! I have added this.
There was a problem hiding this comment.
Sorry, last "request" / "suggestion", can you make sure we don't fail on that command?
There was a problem hiding this comment.
Sure thing. Also, I moved the nydus snapshot cleanup to right before the CRI_RUNTIME stop call. In case this might cause any issues.
ryansavino
force-pushed
the
nydus-cleanup
branch
from
a1b2b7a
to
0fb4a06
Compare
|
/test |
ryansavino
force-pushed
the
nydus-cleanup
branch
from
0fb4a06
to
dd88b7b
Compare
Cleanup created nydus snapshots and var directory Fixes: kata-containers#5787 Signed-Off-By: Ryan Savino <ryan.savino@amd.com>
ryansavino
force-pushed
the
nydus-cleanup
branch
from
dd88b7b
to
c628afe
Compare
|
/test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5787