Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

ci: adding yq-shim to support v3 and v4 #5818

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

beraldoleal
Copy link
Member

Some tests uses yq installed by this repository but other tests might use yq installed by the kata-containers repository.

We are pushing yq to v4 within the main kata repository and this shim will handle only basic syntax of yq v3 and v4 during the transition period.

@katacontainersbot katacontainersbot added the size/medium Average sized task label May 30, 2024
@beraldoleal beraldoleal force-pushed the yq branch 2 times, most recently from ad5dd57 to be34647 Compare May 30, 2024 15:46
@katacontainersbot katacontainersbot added size/large Task of significant size and removed size/medium Average sized task labels May 30, 2024
@beraldoleal
Copy link
Member Author

/test

@beraldoleal
Copy link
Member Author

/test

@beraldoleal beraldoleal force-pushed the yq branch 2 times, most recently from c4c957b to 276dac7 Compare May 30, 2024 18:18
@beraldoleal
Copy link
Member Author

/test

@beraldoleal
Copy link
Member Author

beraldoleal commented May 30, 2024

@wainersm, maybe I'm missing something... but the failed jenkins jobs here are the same as #5819 which is doing nothing. Are those jobs flaky and safe to ignore for this PR?

beraldoleal added a commit to beraldoleal/kata-containers that referenced this pull request May 31, 2024
Since yq frequently updates, let's upgrade to a version from February to
bypass potential issues with versions 4.41-4.43 for now. We can always
upgrade to the newest version if necessary.

Fixes kata-containers#9354
Depends-on:github.com/kata-containers/tests#5818

Signed-off-by: Beraldo Leal <bleal@redhat.com>
beraldoleal added a commit to beraldoleal/kata-containers that referenced this pull request May 31, 2024
Since yq frequently updates, let's upgrade to a version from February to
bypass potential issues with versions 4.41-4.43 for now. We can always
upgrade to the newest version if necessary.

Fixes kata-containers#9354
Depends-on:github.com/kata-containers/tests#5818

Signed-off-by: Beraldo Leal <bleal@redhat.com>
beraldoleal added a commit to beraldoleal/kata-containers that referenced this pull request May 31, 2024
Since yq frequently updates, let's upgrade to a version from February to
bypass potential issues with versions 4.41-4.43 for now. We can always
upgrade to the newest version if necessary.

Fixes kata-containers#9354
Depends-on:github.com/kata-containers/tests#5818

Signed-off-by: Beraldo Leal <bleal@redhat.com>
@wainersm
Copy link
Contributor

@wainersm, maybe I'm missing something... but the failed jenkins jobs here are the same as #5819 which is doing nothing. Are those jobs flaky and safe to ignore for this PR?

I think it's safe; let me ask one more fix: add the Fixes in your commit.

Some tests uses yq installed by this repository but other tests might
use yq installed by the kata-containers repository.

We are pushing yq to v4 within the main kata repository and this shim
will handle only basic syntax of yq v3 and v4 during the transition
period.

Fixes: kata-containers#5820

Signed-off-by: Beraldo Leal <bleal@redhat.com>
@stevenhorsman
Copy link
Member

/test

datadog-compute-robot pushed a commit to DataDog/kata-containers that referenced this pull request Jun 11, 2024
Since yq frequently updates, let's upgrade to a version from February to
bypass potential issues with versions 4.41-4.43 for now. We can always
upgrade to the newest version if necessary.

Fixes kata-containers#9354
Depends-on:github.com/kata-containers/tests#5818

Signed-off-by: Beraldo Leal <bleal@redhat.com>
datadog-compute-robot pushed a commit to DataDog/kata-containers that referenced this pull request Jun 17, 2024
Since yq frequently updates, let's upgrade to a version from February to
bypass potential issues with versions 4.41-4.43 for now. We can always
upgrade to the newest version if necessary.

Fixes kata-containers#9354
Depends-on:github.com/kata-containers/tests#5818

Signed-off-by: Beraldo Leal <bleal@redhat.com>
datadog-compute-robot pushed a commit to DataDog/kata-containers that referenced this pull request Jun 17, 2024
Since yq frequently updates, let's upgrade to a version from February to
bypass potential issues with versions 4.41-4.43 for now. We can always
upgrade to the newest version if necessary.

Fixes kata-containers#9354
Depends-on:github.com/kata-containers/tests#5818

Signed-off-by: Beraldo Leal <bleal@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/large Task of significant size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants