Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add global credentials namespace key #590

Merged
merged 1 commit into from
Jun 18, 2024
Merged

chore: add global credentials namespace key #590

merged 1 commit into from
Jun 18, 2024

Conversation

kycheng
Copy link
Contributor

@kycheng kycheng commented Jun 18, 2024 •
edited
Loading

Changes

chore: add global credentials namespace key

from: https://github.com/katanomi/core/blob/cfdfb89db77e92a5d985ac463c322657e80b6456/pkg/integrations/integrationaddress_dependencies.go#L49-L51

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

@kycheng kycheng merged commit dfb3870 into main Jun 18, 2024
2 checks passed
@kycheng kycheng deleted the fix/global-credentials-config-key branch June 18, 2024 09:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjingfm nanjingfm nanjingfm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kycheng @nanjingfm