Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Go version requirement to 1.20 #17

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

jamietanna
Copy link
Contributor

@jamietanna jamietanna commented Sep 4, 2023

As part of the upgrade to Go 1.21, the Go toolchain now requires the
go directive to match the maximum Go version in use in dependencies.

This leads to any transitive dependency on this library to result in a
requirement of the consuming project moving to Go 1.21.

Although in a lot of cases this may not be as problematic, it forces
consumers to migrate, which we don't need to do in this case.


As discussed in oapi-codegen/oapi-codegen#1221 and related change in gofiber/fiber#2614. See also golang/go#62409

As part of the upgrade to Go 1.21, the Go toolchain now requires the
`go` directive to match the maximum Go version in use in dependencies.

This leads to any transitive dependency on this library to result in a
requirement of the consuming project moving to Go 1.21.

Although in a lot of cases this may not be as problematic, it forces
consumers to migrate, which we don't need to do in this case.
Copy link
Owner

@kataras kataras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want users to be forced to upgrade their Go versions for security reasons but if that issues problems, we can downgrade to 1.20. Thanks

@kataras kataras merged commit dbcc660 into kataras:main Sep 8, 2023
@jamietanna
Copy link
Contributor Author

Thank you! 1.20 is still supported by the Go team so for now will be getting security updates too ☺

@jamietanna jamietanna deleted the chore/go-version branch September 8, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants