Henry/dtra 376/fix: ts migration positionsdrawer folder #27

henry-deriv · 2023-08-28T09:23:51Z

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

coveralls · 2023-08-29T02:45:24Z

Pull Request Test Coverage Report for Build 6008772195

11 of 20 (55.0%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 10.045%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/components/src/components/contract-card/result-overlay/result-overlay.tsx	0	1	0.0%
packages/trader/src/App/Components/Elements/PositionsDrawer/helpers/positions-helper.ts	9	11	81.82%
packages/trader/src/App/Components/Elements/PositionsDrawer/positions-drawer.tsx	0	6	0.0%

Totals
Change from base Build 5961064117:	0.0%
Covered Lines:	10125
Relevant Lines:	84439

💛 - Coveralls

github-actions · 2023-08-29T02:57:34Z

⏳ Generating Lighthouse report...

packages/trader/src/App/Components/Elements/PositionsDrawer/result-mobile.tsx

packages/trader/src/App/Components/Elements/TogglePositions/toggle-positions-mobile.tsx

packages/trader/src/App/Components/Elements/PositionsDrawer/helpers/positions-helper.ts

packages/components/src/components/contract-card/result-overlay/result-overlay.tsx

packages/trader/src/App/Components/Elements/PositionsDrawer/positions-drawer.tsx

maryia-deriv · 2023-08-31T00:55:15Z

packages/trader/src/App/Components/Elements/PositionsDrawer/positions-drawer.tsx

@@ -109,6 +137,7 @@ const PositionsDrawer = observer(({ ...props }) => {
        <DataList
            data_source={positions}
            rowRenderer={args => (
+                // @ts-expect-error not sure how to type row so types are compatible


@henry-deriv what kind of error do you get? I'd like to help :)

Types of property 'row' are incompatible. Type 'TRow' is not assignable to type 'TPortfolioPosition'. const PositionsDrawerCardItem: ({ row: portfolio_position, measure, onHoverPosition, symbol, is_new_row, ...props }: TPositionDrawerCardItem) => JSX.Element

Essentially, TRow which is [key: string]: any is not compatible to TPortfolioPosition which comes from types.ts. Of course i can see that [key: string]: any basically applies to any object like TPortfolioPosition but typesscript doesnt like it.

@henry-deriv I can see you didn't add any type for PositionsDrawer component props:
const PositionsDrawer = observer(({ ...props }: TPositionsDrawerProps) => {
in its props you can add a suitable type for row which most likely will be
row?: { [key: string]: any } | TPortfolioPosition;
:)

yeah i did that before and got rid of the error. I just thought it was an ugly solution

* fix: ts-migrate trade-params * fix: sonarcloud * fix: pull in changes from tech debt 2 package * fix: resolve comments * fix: move type to common prop types * fix: move type to common prop types * fix: move type to common prop types file * fix: resolve comments * Kate / DTRA-321 / TS migration of trade-params and trade-params-mobile (#6) * refactor: migrate trade params and started mobile version * refactor: ts migration of trade params mobile * chore: add nessasary prop * refactor: apply suggestions * chore: change todo text * refactor: add import * fix: circleCI error * fix: ts migrate trade-footer-extensions.jsx * fix: fix import * fix: remove progress-slider-stream since its not used * fix: resolve comments * fix: reset with master * fix: reset with master * fix: reset with master * fix: reset with master * fix: circleCI * fix: togglePositions folder * fix: dtra-346 marketisclosed and marketcountdowntimer migration * fix: bug * Maryia/dtra-270/TS migration: trade-store (#5) * chore: prepare for migration * chore: add more types to trade-store * chore: add more types to trade-store * chore: add more types to trade-store * chore: add more types to trade-store * chore: migrated trade-store to ts * chore: improve types in trade-store * fix: type * revert: hooks package installation * refactor: address review * fix: resolve comments * feat: add ts migartion of store * refactor: add prev changes * chore: empty commit * fix: add lost mocked * fix: resolve comments * Kate / DTRA-354 / Components/Form/Purchase files in Trader package (#21) * refactor: ts migartion of purchase files * refactor: remove duplicated types * refactor: apply suggestions * maryia/fix: sonarcloud warnings (#7) * fix: sonarcloud warnings * fix: Unexpected end of JSON input * fix: bug * fix: sonarcloud * fix: reorder props * fix: test cases * fix: coveralls * fix: coveralls * fix: this component doesnt exist anymore, hence test was also removed * henry/dtra-356/fix: ts-migration-digitsJSX (#24) * fix: initial commit * fix: ts migrate digits JSX * fix: small type change * fix: comment * chore: removed unused state * Maryia/dtra-355/Migrate ContractDrawer files to TS (#22) * feat: migrated swipeable-components to TS * feat: migrated market-closed-contract-overlay & index to TS * chore: migrated contract-drawer-card.tsx to ts * build: fix type * chore: migrated contract-drawer to ts * chore: fixed existing types in digits and logic * chore: sort types properties in alphabetical order * Kate/dtra 357/ts contract audit files (#23) * refactor: apply suggestion from prev pr * refactor: start ts migration of contract audit * chore: change comment * refactor: ts of contract audit item * refactor: ts migration of contract details * refactor: ts migration of contract history * refactor: add preprepared types * refactor: tests * chore: apply nit * refactor: apply suggestions * refactor: apply suggestions * chore: fix of sonar cloud * Maryia/dtra-373/remove localize from ContractCardHeader component (#25) * refactor: remove localize from contract-card-header * refactor: use Localize component instead of localize helper * build: install RTL deps in shared package * feat: merge previous tech debt branch * fix: sonar cloud codesmells * Merge branch kate/ts_migration_trader_package_4 into kate/ts_migration_trader_package_5 * Kate / DTRA-378 / TS migration: Multiplier components and containers in Trader package (#26) * refactor: ts of cancel deal and risk managment info * fix: types in dialog tsx * refactor: start ts of multiplier options * refactor: ts of mult amount modal * refactor: remove default val from basis component * fix: type of amount mobile * refactor: applied suggestions * refactor: ts of multiplier info (#28) * Henry/dtra 376/fix: ts migration positionsdrawer folder (#27) * fix: positions drawer folder * fix: coveralls * fix: where is my commit * fix: found commits * fix: file rename * fix: comments * fix: comments * fix: correct logic * fix: remove unused props * fix: types * refactor: remove code mells * fix: ts-migrate-populate header (#30) * Maryia/DTRA-377/TS migration: TradingDatePicker + TradingTimePicker + TimePicker + Dialog (#29) * chore: timepicker to ts * chore: trading timepicker to ts * chore: add types for TradingDatePicker & DatePicker * refactor: added default values * refactor: remove code small * chore: empty commit * fix: not using index as key (#31) * fix: ternary bug * fix: build TS errors (#32) * refactor: apply suggestions * refactor: change type of time * chore: empty commit * refactor: tests * fix: conflicts * fix: conflicts * fix: tests * fix: types in tests * fix: test extention * fix: add turbos to types back * fix: add backup for target name * fix: revert empty strings --------- Co-authored-by: Henry Hein <henry@regentmarkets.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>

fix: positions drawer folder

0502450

henry-deriv changed the base branch from master to kate/ts_migration_trader_package_5 August 28, 2023 09:24

henry-deriv added 3 commits August 29, 2023 10:04

fix: coveralls

fb07d17

fix: where is my commit

57f8d7b

fix: found commits

555d582

matin-deriv reviewed Aug 29, 2023

View reviewed changes

packages/trader/src/App/Components/Elements/PositionsDrawer/result-mobile.tsx Outdated Show resolved Hide resolved

packages/trader/src/App/Components/Elements/PositionsDrawer/result-mobile.tsx Outdated Show resolved Hide resolved

henry-deriv added 2 commits August 29, 2023 12:08

fix: file rename

0282bf9

fix: comments

3f60b56

matin-deriv reviewed Aug 29, 2023

View reviewed changes

packages/trader/src/App/Components/Elements/TogglePositions/toggle-positions-mobile.tsx Outdated Show resolved Hide resolved

fix: comments

64ca269

matin-deriv approved these changes Aug 29, 2023

View reviewed changes

kate-deriv reviewed Aug 29, 2023

View reviewed changes

packages/trader/src/App/Components/Elements/PositionsDrawer/helpers/positions-helper.ts Outdated Show resolved Hide resolved

kate-deriv reviewed Aug 29, 2023

View reviewed changes

packages/components/src/components/contract-card/result-overlay/result-overlay.tsx Show resolved Hide resolved

fix: correct logic

995cc33

kate-deriv approved these changes Aug 29, 2023

View reviewed changes

maryia-deriv reviewed Aug 31, 2023

View reviewed changes

packages/trader/src/App/Components/Elements/PositionsDrawer/positions-drawer.tsx Outdated Show resolved Hide resolved

maryia-deriv reviewed Aug 31, 2023

View reviewed changes

henry-deriv added 2 commits September 1, 2023 10:16

fix: remove unused props

45ceed7

fix: types

8a5c07d

kate-deriv approved these changes Sep 1, 2023

View reviewed changes

maryia-deriv approved these changes Sep 1, 2023

View reviewed changes

kate-deriv merged commit 22dad33 into kate-deriv:kate/ts_migration_trader_package_5 Sep 1, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Henry/dtra 376/fix: ts migration positionsdrawer folder #27

Henry/dtra 376/fix: ts migration positionsdrawer folder #27

henry-deriv commented Aug 28, 2023

coveralls commented Aug 29, 2023 •

edited

Loading

github-actions bot commented Aug 29, 2023 •

edited

Loading

maryia-deriv Aug 31, 2023

henry-deriv Sep 1, 2023 •

edited

Loading

maryia-deriv Sep 1, 2023

henry-deriv Sep 1, 2023

Henry/dtra 376/fix: ts migration positionsdrawer folder #27

Henry/dtra 376/fix: ts migration positionsdrawer folder #27

Conversation

henry-deriv commented Aug 28, 2023

Changes:

Screenshots:

coveralls commented Aug 29, 2023 • edited Loading

Pull Request Test Coverage Report for Build 6008772195

💛 - Coveralls

github-actions bot commented Aug 29, 2023 • edited Loading

maryia-deriv Aug 31, 2023

Choose a reason for hiding this comment

henry-deriv Sep 1, 2023 • edited Loading

Choose a reason for hiding this comment

maryia-deriv Sep 1, 2023

Choose a reason for hiding this comment

henry-deriv Sep 1, 2023

Choose a reason for hiding this comment

coveralls commented Aug 29, 2023 •

edited

Loading

github-actions bot commented Aug 29, 2023 •

edited

Loading

henry-deriv Sep 1, 2023 •

edited

Loading