Maryia/TS-Package-7/add types for SmartCharts components #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-deriv
changed the base branch from
master
to
kate/DTRA-420/ts_migration_7
maryia-deriv
had a problem deploying
to
Preview
GitHub Actions
Failure
maryia-deriv
had a problem deploying
to
Preview
GitHub Actions
Failure
maryia-deriv
commented
Dec 4, 2023
| export const StudyLegend = React.lazy(load('StudyLegend')); | ||
| export const Views = React.lazy(load('Views')); | ||
| export const ToolbarWidget = React.lazy(load('ToolbarWidget')); | ||
| export const FastMarker = React.lazy(load('FastMarker')); |
There was a problem hiding this comment.
removed export const RawMarker = React.lazy(load('RawMarker')); since it doesn't exist in flutter-chart branch of SmartCharts and not used here anymore.
maryia-deriv
commented
Dec 4, 2023
| portalNodeId?: string; | ||
| }; | ||
|
|
||
| type TSmartChartProps = React.PropsWithChildren<{ |
There was a problem hiding this comment.
types from the removed SmartChartSwitcher https://github.com/kate-deriv/deriv-app/pull/45/files#diff-04bb2774644da792dc593a913b0892dcd4d21c260415ddda81814bd041f85bb1
kate-deriv
approved these changes
Dec 4, 2023
henry-deriv
reviewed
Dec 5, 2023
| type TNotification = { | ||
| category: string; | ||
| text: string; | ||
| type?: 'info' | 'warning' | 'success' | 'error' | 'warning'; |
There was a problem hiding this comment.
I will merge this PR into the parent branch and will remove extra 'warning'
There was a problem hiding this comment.
thank you @kate-deriv :)
henry-deriv
approved these changes
Dec 5, 2023
balakrishna-deriv
approved these changes
Dec 5, 2023
kate-deriv
merged commit b814d0c
into
kate-deriv:kate/DTRA-420/ts_migration_7
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: