feat: added step 4 for onboarding in dtrader v2 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-deriv
reviewed
Aug 30, 2024
| {isAccumulatorContract(contract_type) && <AccumulatorStats />} | ||
| </div> | ||
| <div className='trade__bottom'> | ||
| <span className='trade__bottom'> |
There was a problem hiding this comment.
Does it complain, that in span we have block tags?
There was a problem hiding this comment.
I have made this change
kate-deriv
reviewed
Aug 30, 2024
| @@ -90,7 +116,8 @@ const GuideContainer = ({ should_run, onFinishGuide }: TGuideContainerProps) => | |||
| borderRadius: 'unset', | |||
| }, | |||
| }} | |||
| run={should_run} | |||
| stepIndex={step_index} | |||
| tooltipComponent={props => <GuideTooltip {...props} setStepIndex={setStepIndex} />} | |||
kate-deriv
reviewed
Aug 30, 2024
kate-deriv
reviewed
Aug 30, 2024
packages/trader/src/AppV2/Components/OnboardingGuide/guide-tooltip.tsx
Outdated
Show resolved
Hide resolved
kate-deriv
reviewed
Aug 30, 2024
packages/trader/src/AppV2/Components/OnboardingGuide/guide-tooltip.tsx
Outdated
Show resolved
Hide resolved
kate-deriv
reviewed
Aug 30, 2024
packages/trader/src/AppV2/Components/OnboardingGuide/guide-tooltip.tsx
Outdated
Show resolved
Hide resolved
kate-deriv
reviewed
Aug 30, 2024
packages/trader/src/AppV2/Components/OnboardingGuide/onboarding-guide.scss
Outdated
Show resolved
Hide resolved
kate-deriv
merged commit 378990c
into
kate-deriv:vinu/kate/DTRA-1670/user_onboarding_guide
1 check failed
kate-deriv
added a commit
that referenced
this pull request
Sep 5, 2024
…-com#16589) * feat: add npm package, prepare local store and create a base modal for starting guide * feat: add guide container and tooltip component * refactor: tooltip componnet * refactor: set flag to trye on finish and styling * fix: close and skip functionality * feat: add the video * feat: add step 3 and inprove tooltip width * feat: add steps 3 5 6 and remove skip button * refactor: make guide modal reusable for positions page * refactor: add tests * feat: added step 4 for onboarding in dtrader v2 (#82) * feat: added step 4 for onboarding in dtrader v2 * fix: resolved code suggestion * fix: replaced pixel for scroll icon with quill token * refactor: update quill ui refactor onboarding guide functions and fix tests * fix: link console error * refactor: apply suggestions * chore: update quill --------- Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.