Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for arm64 architecture. #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ywoelker
Copy link

With the new Apple M1 chips (arm64 architecture) the conversion of Docker images to Singularity images with this container needs twice as much time. I tried to add support for building this Docker image with the amd64 and arm64 architecture and upload both of them to Docker Hub so no one has to care and can pull the image with the matching architecture.

@kathoef
Copy link
Owner

kathoef commented May 15, 2022

Thank you a lot! It took a while, but today I finally had the time to look into your PR. It seems, there were a bit more Github actions related things to add in order to make the arm64 build work.

Since at the moment, unfortunately, I don't have time to work on such projects together, I took the shortcut and implemented further required changes in #4 myself. (This also includes changes to the Go binary architecture and to Singularity itself, which is now maintained as Apptainer, and was not installing anymore from the URL that was specified in the Dockerfile.)

I would be very happy, if you could test the arm64 image that will be available on Dockerhub when the currently running workflow succeeded, and if you could provide a PR with container build example commands for the README.md? Of particular interest: How to build and convert amd64 container images on arm64 machines, which is, I suppose, what should be done for running the Singularity image on the target HPC system architecture? @willirath mentioned you did a few tests and having details about how to do this would be very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants