Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: [Regions] allow setting content and id #3154

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3124

Implementation details

Allows setting region's content and id via region.setOptions.
E.g.

region.setOptions({
  id: 'new-id',
  content: 'New content'
})

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 31, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 77b423e
Status: ✅  Deploy successful!
Preview URL: https://94f38cb5.wavesurfer-js.pages.dev
Branch Preview URL: https://regions-content.wavesurfer-js.pages.dev

View logs

@katspaugh katspaugh merged commit b1dd4a6 into main Aug 31, 2023
4 checks passed
@katspaugh katspaugh deleted the regions-content branch August 31, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant