Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Timeline] render on initial redraw #3327

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix: [Timeline] render on initial redraw #3327

merged 1 commit into from
Nov 8, 2023

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3314

Implementation details

If audio duration is known from the start, render the Timeline immediately.

Copy link

cloudflare-workers-and-pages bot commented Nov 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff95284
Status: ✅  Deploy successful!
Preview URL: https://8e438f59.wavesurfer-js.pages.dev
Branch Preview URL: https://fix-timeline.wavesurfer-js.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Nov 8, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit 7509ea3 into main Nov 8, 2023
@katspaugh katspaugh deleted the fix-timeline branch November 8, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline plugin is not rendered until setOptions is called if not created within WaveSurfer.create(...)
1 participant