Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: dragstart and dragend events for drag to seek #3562

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

brian-byassee
Copy link
Contributor

Short description

Add dragstart and dragend events for drag to seek feature.

Resolves #

Implementation details

Add two new events and updated the functions passed to makeDraggable to make start and end emit the new event

How to test it

http://127.0.0.1:9090/#all-options.js
Add

wavesurfer.on('drag', (x) => console.log('drag',x))
wavesurfer.on('dragstart', (x) => console.log('dragstart',x))
wavesurfer.on('dragend', (x) => console.log('dragend',x))

check box to make Drag to Seek active.

Observe console.

Screenshots

Checklist

  • This PR is covered by e2e tests
  • It introduces no breaking API changes

Copy link
Owner

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@katspaugh katspaugh merged commit 5e8c07a into katspaugh:main Feb 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants