Skip to content

Commit

Permalink
Changed compile to implementation
Browse files Browse the repository at this point in the history
  • Loading branch information
@katzer
katzer committed Nov 29, 2018
1 parent 85b1a95 commit 8e870f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/android/badge.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ if (!project.ext.has('appShortcutBadgerVersion')) {

if (!project.ext.has('appShortcutBadgerCustom')) {
dependencies {
compile "me.leolin:ShortcutBadger:${appShortcutBadgerVersion}@aar"
implementation "me.leolin:ShortcutBadger:${appShortcutBadgerVersion}@aar"
}
}

6 comments on commit 8e870f7

@danespecno
Copy link

@danespecno danespecno commented on 8e870f7 Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't pushed as an update to NPM,
Would you please bump the package version with this change.

0.8.8 is currently without this change

@justvamp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katzer It would be really nice to release a new version with this change.

For those who need this change right now, there's a workaround: just use "cordova-plugin-badge": "github:katzer/cordova-plugin-badge#8e870f7f", in your package.json.

@adamk22
Copy link

@adamk22 adamk22 commented on 8e870f7 Dec 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the version from above as well, would be nice if this fix can be added to an updated version

@katzer
Copy link
Owner Author

@katzer katzer commented on 8e870f7 Apr 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally done...

@RenzoPH
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I encountered this issue. may I know if you encounted also this one

FAILURE: Build failed with an exception.

  • Where:
    Script '/Users/runner/work/1/s/node_modules/cordova-plugin-local-notification/src/android/build/localnotification.gradle' line: 31

  • What went wrong:
    A problem occurred evaluating script.

Could not find method compile() for arguments [me.leolin:ShortcutBadger:1.1.22@aar] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

  • Try:

Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

@ShaneJohnsonCC
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having this same issue! Did you figure out what is going on @RenzoPH ?

Please sign in to comment.