Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MathJax to v3 #9

Closed
wants to merge 2 commits into from
Closed

Update MathJax to v3 #9

wants to merge 2 commits into from

Conversation

benide
Copy link
Contributor

@benide benide commented Oct 27, 2019

I used this tool to convert the config. Assuming this doesn't break any tests, this can close kaushalmodi/ox-hugo#297.

@benide
Copy link
Contributor Author

benide commented Oct 27, 2019

It does seem to work with everything I had used it with before, but I'm finding there are some things I can improve on. Don't merge just yet!

remove unnecessary options
423093e 
All of the removed options were autogenerated. It turns out that they were set to the default values and did not need to be included.
@benide
Copy link
Contributor Author

benide commented Oct 27, 2019

OK, the only things I can find wrong with this are already fixed over at the mathjax repo, but not in an official release yet. mathjax/MathJax#2186 is a little annoying but certainly not breaking. mathjax/MathJax-src#335 could be breaking for people using amsCd, but will be fixed in 3.0.1. Other than the first (non-breaking) bug I linked, I think nothing should change on your test site. Importantly, \ref{...} still works.

@kaushalmodi
Copy link
Owner

Thanks! Merging this.

kaushalmodi pushed a commit that referenced this pull request Oct 28, 2019
@kaushalmodi
Update MathJax to v3
4958d99 
Ref:
- kaushalmodi/ox-hugo#297
- https://docs.mathjax.org/en/latest/upgrading/v2.html
- https://mathjax.github.io/MathJax-demos-web/convert-configuration/convert-configuration.html

Credit goes to @benide for their PR:
#9.
@kaushalmodi
Copy link
Owner

Manually merged in 4958d99.

rossabaker pushed a commit to rossabaker/cromulent that referenced this pull request Aug 9, 2022
@kaushalmodi
Update MathJax to v3
b5afea6 
Ref:
- kaushalmodi/ox-hugo#297
- https://docs.mathjax.org/en/latest/upgrading/v2.html
- https://mathjax.github.io/MathJax-demos-web/convert-configuration/convert-configuration.html

Credit goes to @benide for their PR:
kaushalmodi/hugo-bare-min-theme#9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MathJax v3
2 participants
@benide @kaushalmodi