Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SQL] Do not register SQL if not supported in cluster #6

Open
3 tasks
kavilla opened this issue Jun 14, 2024 · 0 comments
Open
3 tasks

feat: [SQL] Do not register SQL if not supported in cluster #6

kavilla opened this issue Jun 14, 2024 · 0 comments

Comments

@kavilla
Copy link
Owner

kavilla commented Jun 14, 2024

Regardless if Observability or the SQL plugin installed in the cluster. We still register the language. [SOURCE]

Which lets the language be selectable but one selected bug like this gets reported:

Switch from DQL to SQL/PPL: can't search SQL/PPL anymore. To add onto this, I think something's wrong with the SQL/PPL endpoints. getting a Error: {"error":"no handler found for uri [/_plugins/_sql] and method [POST]"}

Expected results

SQL does NOT get registered and displayed in language selector

Action items

  • Research approaches
    • some ideas but not limited to:
      • Using the capability service (example)
      • Alternative could be not starting the plugin unless Observability and SQL are installed with requiredEnginedPlugins [info]
      • use the dependences [example]
        • might not work because we are talking an engine plugin, might just have to HEAD request to _plugins/sql
    • in a world where data sources can be not limited to the local cluster. do we want to consider registering regardless and then within the data source work we have supported languages for data sources
  • Implement
  • Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant