-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Decouple] Allow plugin manifest config to define semver compatible OpenSearch plugin and verify if it is installed on the cluster #4612
Conversation
26a489d
to
7cc777e
Compare
Codecov Report
@@ Coverage Diff @@
## main #4612 +/- ##
==========================================
+ Coverage 66.28% 66.31% +0.02%
==========================================
Files 3322 3322
Lines 63923 63933 +10
Branches 10117 10121 +4
==========================================
+ Hits 42371 42395 +24
+ Misses 19061 19050 -11
+ Partials 2491 2488 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@kavilla Assigned you as primary reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good I would just update this one to be the string:string and good to merge.
7cc777e
to
f688747
Compare
f688747
to
b8cb12d
Compare
JSON.stringify({ | ||
id: 'test-invalid-version-type-plugin', | ||
version: '7.0.0', | ||
requiredEnginePlugins: { 'invalid-plugin-version-range': 2 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought semver
was able to convert this to ^2.0.0
; no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm doing semver.coerce
when reading the version from engine, but this is coming from plugin manifest file and we still expect plugin users to write it in actual semver
format. Hence there is a validation check on if the defined version is valid semver
range or not.
b8cb12d
to
967823d
Compare
…lugin and verify if it is installed on the cluster Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
967823d
to
bc80e28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool! I think if there is any clean ups or changes to how we want to do it it can be done in a follow-up but I don't see anything right away. So let's let it bake in main
for a little.
Description
This PR is an enhancement to the already existing plugin manifest ability to allow defining backend OpenSearch plugin dependencies. As part of decoupling Dashboards with OpenSearch Dashboards plugins and then with OpenSearch, we need a way to establish Dashboards plugin dependency with its counter part.
This PR adds following changes -
requiredOpenSearchPlugins
to define list of OpenSearch Plugin object and its version compatibility with that plugin.In the follow-up PRs,
Issues Resolved
#4611
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr