Skip to content

Commit

Permalink
fix build due to vmware fmt and gomod issues
Browse files Browse the repository at this point in the history
  • Loading branch information
kavya498 committed Apr 25, 2024
1 parent 6c7c7d9 commit 2e3faac
Show file tree
Hide file tree
Showing 8 changed files with 41 additions and 38 deletions.
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ require (
github.com/IBM/go-sdk-core v1.1.0
github.com/IBM/mqcloud-go-sdk v0.0.4
github.com/IBM/sarama v1.41.2
github.com/IBM/vmware-go-sdk v0.1.2
github.com/stretchr/testify v1.9.0
k8s.io/utils v0.0.0-20230313181309-38a27ef9d749
sigs.k8s.io/controller-runtime v0.14.1
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ github.com/IBM/schematics-go-sdk v0.2.3 h1:lgTt0Sbudii3cuSk1YSQgrtiZAXDbBABAoVj3
github.com/IBM/schematics-go-sdk v0.2.3/go.mod h1:Tw2OSAPdpC69AxcwoyqcYYaGTTW6YpERF9uNEU+BFRQ=
github.com/IBM/secrets-manager-go-sdk/v2 v2.0.4 h1:xa9e+POVqaXxXHXkSMCOVAbKdUNEu86jQmo5hcpd+L4=
github.com/IBM/secrets-manager-go-sdk/v2 v2.0.4/go.mod h1:5gq8D8uWOIbqOm1uztay6lpOysgJaxxEsaVZLWGWb40=
github.com/IBM/vmware-go-sdk v0.1.2 h1:5lKWFyInWz9e2hwGsoFTEoLa1jYkD30SReN0fQ10w9M=
github.com/IBM/vmware-go-sdk v0.1.2/go.mod h1:2UGPBJju3jiv5VKKBBm9a5L6bzF/aJdKOKAzJ7HaOjA=
github.com/IBM/vpc-beta-go-sdk v0.6.0 h1:wfM3AcW3zOM3xsRtZ+EA6+sESlGUjQ6Yf4n5QQyz4uc=
github.com/IBM/vpc-beta-go-sdk v0.6.0/go.mod h1:fzHDAQIqH/5yJmYsKodKHLcqxMDT+yfH6vZjdiw8CQA=
github.com/IBM/vpc-go-sdk v0.50.0 h1:+vnXYK0FXFXYqaS/5/X1XEqH0bbRotkzkerRk21ZEjE=
Expand Down
10 changes: 5 additions & 5 deletions ibm/conns/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ import (
project "github.com/IBM/project-go-sdk/projectv1"
"github.com/IBM/push-notifications-go-sdk/pushservicev1"
schematicsv1 "github.com/IBM/schematics-go-sdk/schematicsv1"
"github.com/IBM/vmware-go-sdk/vmwarev1"
vpcbeta "github.com/IBM/vpc-beta-go-sdk/vpcbetav1"
"github.com/IBM/vpc-go-sdk/common"
vpc "github.com/IBM/vpc-go-sdk/vpcv1"
"github.com/IBM/vmware-go-sdk/vmwarev1"
"github.com/apache/openwhisk-client-go/whisk"
jwt "github.com/golang-jwt/jwt"
slsession "github.com/softlayer/softlayer-go/session"
Expand Down Expand Up @@ -630,8 +630,8 @@ type clientSession struct {
mqcloudClientErr error

// VMware as a Service
vmwareClient *vmwarev1.VmwareV1
vmwareClientErr error
vmwareClient *vmwarev1.VmwareV1
vmwareClientErr error
}

// Usage Reports
Expand Down Expand Up @@ -3270,7 +3270,7 @@ func (c *Config) ClientSession() (interface{}, error) {
vmwareURL := ContructEndpoint(fmt.Sprintf("api.%s.vmware", c.Region), cloudEndpoint+"/v1")
vmwareClientOptions := &vmwarev1.VmwareV1Options{
Authenticator: authenticator,
URL: EnvFallBack([]string{"VMWARE_URL"}, vmwareURL),
URL: EnvFallBack([]string{"VMWARE_URL"}, vmwareURL),
}

// Construct the service client.
Expand All @@ -3280,7 +3280,7 @@ func (c *Config) ClientSession() (interface{}, error) {
session.vmwareClient.Service.EnableRetries(c.RetryCount, c.RetryDelay)
// Add custom header for analytics
session.vmwareClient.SetDefaultHeaders(gohttp.Header{
"X-Original-User-Agent": { fmt.Sprintf("terraform-provider-ibm/%s", version.Version) },
"X-Original-User-Agent": {fmt.Sprintf("terraform-provider-ibm/%s", version.Version)},
})
} else {
session.vmwareClientErr = fmt.Errorf("Error occurred while configuring VMware as a Service API service: %q", err)
Expand Down
4 changes: 2 additions & 2 deletions ibm/service/vmware/data_source_ibm_vmaas_vdc.go
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ func dataSourceIbmVmaasVdcRead(context context.Context, d *schema.ResourceData,

edges := []map[string]interface{}{}
if vDC.Edges != nil {
for _, modelItem := range vDC.Edges {
for _, modelItem := range vDC.Edges {
modelMap, err := dataSourceIbmVmaasVdcEdgeToMap(&modelItem)
if err != nil {
return diag.FromErr(err)
Expand All @@ -380,7 +380,7 @@ func dataSourceIbmVmaasVdcRead(context context.Context, d *schema.ResourceData,

statusReasons := []map[string]interface{}{}
if vDC.StatusReasons != nil {
for _, modelItem := range vDC.StatusReasons {
for _, modelItem := range vDC.StatusReasons {
modelMap, err := dataSourceIbmVmaasVdcStatusReasonToMap(&modelItem)
if err != nil {
return diag.FromErr(err)
Expand Down
18 changes: 9 additions & 9 deletions ibm/service/vmware/data_source_ibm_vmaas_vdc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,17 +75,17 @@ func TestAccIbmVmaasVdcDataSourceAllArgs(t *testing.T) {
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "director_site.#"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "edges.#"),
/*
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "edges.0.id"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "edges.0.size"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "edges.0.status"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "edges.0.type"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "edges.0.version"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "edges.0.id"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "edges.0.size"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "edges.0.status"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "edges.0.type"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "edges.0.version"),
*/
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "status_reasons.#"),
/*
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "status_reasons.0.code"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "status_reasons.0.message"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "status_reasons.0.more_info"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "status_reasons.0.code"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "status_reasons.0.message"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "status_reasons.0.more_info"),
*/
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "name"),
resource.TestCheckResourceAttrSet("data.ibm_vmaas_vdc.vmaas_vdc_instance", "ordered_at"),
Expand Down Expand Up @@ -120,7 +120,7 @@ func testAccCheckIbmVmaasVdcDataSourceConfigBasic(ds_id string, ds_pvdc_id strin
data "ibm_vmaas_vdc" "vmaas_vdc_instance" {
vmaas_vdc_id = ibm_vmaas_vdc.vmaas_vdc_instance.id
}
`,ds_id, ds_pvdc_id, vDCName)
`, ds_id, ds_pvdc_id, vDCName)
}

func testAccCheckIbmVmaasVdcDataSourceConfig(vDCCpu string, ds_id string, ds_pvdc_id string, vDCName string, vDCRam string, vDCFastProvisioningEnabled string, vDCRhelByol string, vDCWindowsByol string) string {
Expand Down
34 changes: 17 additions & 17 deletions ibm/service/vmware/resource_ibm_vmaas_vdc.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,24 +20,24 @@ import (

func ResourceIbmVmaasVdc() *schema.Resource {
return &schema.Resource{
CreateContext: resourceIbmVmaasVdcCreate,
ReadContext: resourceIbmVmaasVdcRead,
UpdateContext: resourceIbmVmaasVdcUpdate,
DeleteContext: resourceIbmVmaasVdcDelete,
Importer: &schema.ResourceImporter{},
CreateContext: resourceIbmVmaasVdcCreate,
ReadContext: resourceIbmVmaasVdcRead,
UpdateContext: resourceIbmVmaasVdcUpdate,
DeleteContext: resourceIbmVmaasVdcDelete,
Importer: &schema.ResourceImporter{},

Schema: map[string]*schema.Schema{
"accept_language": &schema.Schema{
Type: schema.TypeString,
Optional: true,
Type: schema.TypeString,
Optional: true,
ValidateFunc: validate.InvokeValidator("ibm_vmaas_vdc", "accept_language"),
Description: "Language.",
Description: "Language.",
},
"cpu": &schema.Schema{
Type: schema.TypeInt,
Optional: true,
Type: schema.TypeInt,
Optional: true,
ValidateFunc: validate.InvokeValidator("ibm_vmaas_vdc", "cpu"),
Description: "The vCPU usage limit on the virtual data center (VDC). Supported for VDCs deployed on a multitenant Cloud Director site. This property is applicable when the resource pool type is reserved.",
Description: "The vCPU usage limit on the virtual data center (VDC). Supported for VDCs deployed on a multitenant Cloud Director site. This property is applicable when the resource pool type is reserved.",
},
"director_site": &schema.Schema{
Type: schema.TypeList,
Expand Down Expand Up @@ -92,16 +92,16 @@ func ResourceIbmVmaasVdc() *schema.Resource {
},
},
"name": &schema.Schema{
Type: schema.TypeString,
Required: true,
Type: schema.TypeString,
Required: true,
ValidateFunc: validate.InvokeValidator("ibm_vmaas_vdc", "name"),
Description: "A human readable ID for the virtual data center (VDC).",
Description: "A human readable ID for the virtual data center (VDC).",
},
"ram": &schema.Schema{
Type: schema.TypeInt,
Optional: true,
Type: schema.TypeInt,
Optional: true,
ValidateFunc: validate.InvokeValidator("ibm_vmaas_vdc", "ram"),
Description: "The RAM usage limit on the virtual data center (VDC) in GB (1024^3 bytes). Supported for VDCs deployed on a multitenant Cloud Director site. This property is applicable when the resource pool type is reserved.",
Description: "The RAM usage limit on the virtual data center (VDC) in GB (1024^3 bytes). Supported for VDCs deployed on a multitenant Cloud Director site. This property is applicable when the resource pool type is reserved.",
},
"fast_provisioning_enabled": &schema.Schema{
Type: schema.TypeBool,
Expand Down
2 changes: 1 addition & 1 deletion ibm/service/vmware/resource_ibm_vmaas_vdc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import (
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"

acc "github.com/IBM-Cloud/terraform-provider-ibm/ibm/acctest"
"github.com/IBM-Cloud/terraform-provider-ibm/ibm/conns"
"github.com/IBM/vmware-go-sdk/vmwarev1"
acc "github.com/IBM-Cloud/terraform-provider-ibm/ibm/acctest"
)

func TestAccIbmVmaasVdcBasic(t *testing.T) {
Expand Down
8 changes: 4 additions & 4 deletions ibm/service/vmware/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func waitForVdcStatusUpdate(context context.Context, d *schema.ResourceData, met
getVdcOptions := &vmwarev1.GetVdcOptions{}

getVdcOptions.SetID(d.Id())

vdc, response, err := vmwareClient.GetVdcWithContext(context, getVdcOptions)
if err != nil {
if response != nil && response.StatusCode == 404 {
Expand All @@ -60,7 +60,7 @@ func waitForVdcStatusUpdate(context context.Context, d *schema.ResourceData, met

if *vdc.Status == "ready_to_use" {
return vdc, VdcFinalState, nil
} else if *vdc.Status == "failed" {
} else if *vdc.Status == "failed" {
return vdc, VdcFinalState, fmt.Errorf("%s", err)
}
return vdc, VdcCreatingState, nil
Expand All @@ -85,9 +85,9 @@ func waitForVdcToDelete(context context.Context, d *schema.ResourceData, meta in
getVdcOptions := &vmwarev1.GetVdcOptions{}

getVdcOptions.SetID(d.Id())

vdc, response, err := vmwareClient.GetVdcWithContext(context, getVdcOptions)

if err != nil {
if response != nil && response.StatusCode == 404 {
fmt.Println("The vdc is deleted.")
Expand Down

0 comments on commit 2e3faac

Please sign in to comment.