Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fetchDatabase on mirror-box #792

Merged

Conversation

asaadam
Copy link
Contributor

@asaadam asaadam commented Sep 8, 2021

Closes #785

Description

add fetchDatabase on mirror-box

@netlify
Copy link

netlify bot commented Sep 8, 2021

✔️ Deploy Preview for wargabantuwarga ready!

🔨 Explore the source changes: 708fc3b

🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/613a0ee51d3f0d0007f45f33

😎 Browse the preview: https://deploy-preview-792--wargabantuwarga.netlify.app

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #792 (708fc3b) into main (9a7ab72) will increase coverage by 0.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
+ Coverage   86.30%   86.96%   +0.66%     
==========================================
  Files         134      133       -1     
  Lines        1438     1427      -11     
  Branches      458      458              
==========================================
  Hits         1241     1241              
+ Misses        193      182      -11     
  Partials        4        4              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7ab72...708fc3b. Read the comment docs.

etc/mirror-box.ts Outdated Show resolved Hide resolved
etc/mirror-box.ts Outdated Show resolved Hide resolved
@asaadam asaadam requested a review from zainfathoni September 9, 2021 13:59
Copy link
Member

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Thanks for working on it, @asaadam! 🙏

@zainfathoni zainfathoni merged commit 8238696 into kawalcovid19:main Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fetch-database.ts in mirror-box.ts
2 participants