catching up with upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version string will be injected at release step with the output of `git describe --tags --always`. This fixes #83.
This fixes #143 by parsing elements with VR=AT as Ints (instead of the default fallback of parsing as strings).
…sion. (#155) This adds a more comprehensive test for converting NativeFrame data into an image, and also fixes the row selector in GetImage.
This updates the way the VERSION Makefile variable works.
…Hub Action (#158) * Add -count=5 to benchmark GitHub Action * Update to go 1.15
This change adds dedicated benchmark GitHub actions (to be triggered on pushes and pull requests), in addition to modernizing and cleaning up the Go Build/Test GitHub action.
This adds comprehensive benchmarks (and tests) specifically for readNativeFrames.
This change reduces the number of allocations in `readNativeFrames`. Instead of allocating a slice for each pixel's samples, a single flat buffer slice is allocated upfront of the size `pixelsPerFrame*samplesPerPixel`. Later, ranges in that slice are referred to in the larger 2D slice. This leads to there only being two calls to `make`, leading to significant performance gains. On my machine running `make bench-diff`: ``` name old time/op new time/op delta Parse/1.dcm-8 2.29ms ± 1% 1.95ms ± 3% -15.00% (p=0.008 n=5+5) Parse/2.dcm-8 2.27ms ± 1% 1.94ms ± 0% -14.41% (p=0.008 n=5+5) Parse/3.dcm-8 2.10ms ± 0% 1.81ms ± 2% -13.77% (p=0.008 n=5+5) Parse/4.dcm-8 240ms ± 1% 196ms ± 4% -18.27% (p=0.008 n=5+5) Parse/5.dcm-8 33.6ms ± 1% 27.9ms ± 0% -17.00% (p=0.008 n=5+5) ``` We see similar results in the [GitHub action benchmark](https://github.com/suyashkumar/dicom/pull/157/checks?check_run_id=1574909456#step:5:26). Presumably the percentage performance gains would be even higher for DICOMs with more Native PixelData (e.g. more frames, pixels per frame, samples per pixel, etc). This helps address #161.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.