Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #8: Add --exclude-comments|-e flag to not include comments in… #10

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

juraj-blahunka
Copy link
Member

Fixes #8 – adds options to exclude comments in the formatted output. To test, run

swift build
.build/arm64-apple-macosx/debug/SwiftGenStrings Tests/SwiftGenStringsTests/Resources/testUnescapesDoublyEscapedUnicodeCodePoints.txt --exclude-comments

Copy link
Contributor

@henrik-dmg henrik-dmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Ran all tests locally and everything works as expected 🙂
Could you also update the README to include the new flag, please?

Sources/SwiftGenStringsCore/LocalizedString.swift Outdated Show resolved Hide resolved
@juraj-blahunka juraj-blahunka force-pushed the feature/8-add-option-to-exclude-comments branch from 16a5bd8 to 731ad6e Compare April 14, 2023 06:11
@juraj-blahunka juraj-blahunka merged commit 3845735 into main Apr 14, 2023
@juraj-blahunka juraj-blahunka deleted the feature/8-add-option-to-exclude-comments branch April 14, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request - change output format
2 participants