Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/zip using symlinks option #19

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

Pispa339
Copy link
Contributor

We're currently archiving the build directory with the zip command without using the --symlinks option. This causes all symlink information to go missing from the resulting archive and the unarchived build directory. This causes frameworks using symlinks to fail the signature verification in some cases e.g. Firebase.

Added the --symlinks option to the zip command, bumped up the version number and updated gems. Tested and verified the fix locally.

Copy link
Member

@juraj-blahunka juraj-blahunka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! An example of how a single line change drastically changes the outcome :)

@Pispa339 Pispa339 merged commit 56ed048 into master Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants