-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Big Update] Implement separate callbacks class #21
Conversation
This reverts commit a031247.
Hi @lannguyen0910 , welcome to the project. Can you help me test this branch? See whether the callbacks are simple to use and customize then give me some feedbacks/suggestion. |
There is a CALLBACK_REGISTRY in which contains all callbacks function that are registered in pipeline.yaml file. All new callback classes must be defined with the same method names as in |
@kaylode I have tested on the classification + segmentation on this branch.
In segmentation:
I think my attempt is wrong because the sanity check plot this. Overall, the callbacks works good, no major problems, i will take a deep look in the code again to see if there is minor bugs or improvements, i will be testing on WandB too. |
Yes, I've been experiencing this as well. Basically it is due to the version of timm models. I think your suggestion is fine, do you know how can we include that in
Yes, this happened because we must define a different _load_mask() function for the specific dataset (CarvanaCar in this case). The default _load_mask() in the current settings works for masks in which each pixel present a class. Thank you very much, I'm gonna merge this branch and if there are any more bugs we will fix that later. p/s: if you want to comment on any parts of the template that you see inconvenient or unnecessary, or want to contribute improvement, just create a new branch and make a PR. :> |
Solves #19 |
Helps Trainer more generalized and easy to be modified/intergrated