Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loguru #25

Merged
merged 15 commits into from
Mar 27, 2022
Merged

Loguru #25

merged 15 commits into from
Mar 27, 2022

Conversation

kaylode
Copy link
Owner

@kaylode kaylode commented Mar 26, 2022

  • Use loguru for logging

@kaylode kaylode added the enhancement New feature or request label Mar 26, 2022
@kaylode kaylode self-assigned this Mar 26, 2022
@kaylode
Copy link
Owner Author

kaylode commented Mar 26, 2022

@lannguyen0910 , can you test this branch for me? This is just a simple usage while Loguru also has many cool features that I haven't used yet.

kaylode and others added 5 commits March 26, 2022 19:53
timm loss "RuntimeError: gather(): Expected dtype int64 for index"
"RuntimeError: one_hot is only applicable to index tensor."
@lannguyen0910
Copy link
Collaborator

@lannguyen0910 , can you test this branch for me? This is just a simple usage while Loguru also has many cool features that I haven't used yet.

I've tested and the logger worked fine, it logged the same text as the previous one, the difference is it looks prettier and neater, i also notice that once we use some other features of Loguru it's gonna look more legit than before.

@kaylode
Copy link
Owner Author

kaylode commented Mar 27, 2022

@lannguyen0910 , can you test this branch for me? This is just a simple usage while Loguru also has many cool features that I haven't used yet.

I've tested and the logger worked fine, it logged the same text as the previous one, the difference is it looks prettier and neater, i also notice that once we use some other features of Loguru it's gonna look more legit than before.

Ok thank you. Can you revert the fixes in loss functions in this branch and open issues for them. I've tested both the losses and can't reproduce the error, it would be nice if you add the settings to reproduce that.

@lannguyen0910
Copy link
Collaborator

oh okay, i don't know why i faced those error while testing, i'm gonna revert and open issues if anything is wrong again.

@lannguyen0910
Copy link
Collaborator

lannguyen0910 commented Mar 27, 2022

@kaylode i used revert but it didn't change my commits so i hot deleted them, sorry if it annoys you with the unnecessary commits, or it makes you have difficulty in merging the PR ...

@kaylode
Copy link
Owner Author

kaylode commented Mar 27, 2022

It's fine. Just remember to open a new issue next time

@kaylode kaylode merged commit 276250e into master Mar 27, 2022
@kaylode kaylode deleted the loguru branch March 27, 2022 08:15
@kaylode kaylode mentioned this pull request Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants