Support custom ports #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer assume the port is 443/SSL
kayrus
reviewed
May 19, 2022
pkg/link/link.go
Outdated
| serverIPs, err := net.LookupIP(server) | ||
| servername := strings.SplitN(server, ":", -1)[0] | ||
| serverport := strings.SplitN(server, ":", -1)[1] | ||
| log.Printf("Eggz: Server: %q", servername) |
|
Thanks for a PR. I'd suggest to use https://pkg.go.dev/net#SplitHostPort to obtain hostname and port |
|
Oh, im not even a GO dev. You can deny my pull request and change it as you see fit, but I can confirm this is a working concept when you give a server url with a custom port. for example, It will probably fail when you dont give a port in the url, so this pull request is just a sloppy proof of concept. You prolly have to fall back to the default 443 port when no port is given or something like that. |
Signed-off-by: egnappahz <egnappah@gmail.com>
I mean, really?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer assume the port is 443/SSL