Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to handle sub-libraries in .cabal file. #14

Closed
wants to merge 3 commits into from
Closed

Update to handle sub-libraries in .cabal file. #14

wants to merge 3 commits into from

Conversation

khibino
Copy link
Contributor

@khibino khibino commented Aug 25, 2021 •
edited
Loading

This change is to pick up the sub-library entry in the .cabal file.
An example has been implemented in the test.

@khibino khibino marked this pull request as ready for review August 25, 2021 09:32
@kazu-yamamoto kazu-yamamoto self-requested a review February 2, 2022 07:46
kazu-yamamoto
kazu-yamamoto approved these changes Feb 2, 2022
View reviewed changes
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto
Copy link
Owner

@khibino Which version of GHC are you using? I would like to merge this to the ghc9 branch, if possible, which does not suport GHC 8.x at all.

@khibino khibino mentioned this pull request Feb 17, 2022
Merged
kazu-yamamoto added a commit that referenced this pull request Feb 17, 2022
@kazu-yamamoto
Merge PR #14
1e8c6b6
@kazu-yamamoto
Copy link
Owner

Rebased & merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khibino @kazu-yamamoto