Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More time-ordered logging functions, fix newFastLogger1 #199

Closed

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Nov 22, 2021

See individual commits.

Fixes 6ddf3c7#r60660256.

Why is this change important?

For my logging use cases (and I'd argue, for many), I require time-ordered output. Until now, this was not configurable for stdout/stderr.

This is useful when you already have an FD at hand,
which can make it easier for users to write logic that avoids
avoid race conditions in the file system (e.g. atomically
creating a file and then writing to it, or writing to `O_TMPFILE`
files).
@kazu-yamamoto kazu-yamamoto self-requested a review January 20, 2022 07:07
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I don't know why I missed this issue.
This PR looks good to me.

@kazu-yamamoto
Copy link
Owner

Rebased and merged. Thank you for your contribution!

kazu-yamamoto added a commit that referenced this pull request Jan 20, 2022
@kazu-yamamoto
Copy link
Owner

A new version has been released.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 11, 2022
3.1.1
* More time-ordered logging functions
  [#199](kazu-yamamoto/logger#199

3.1.0
* Having a single Buffer in LoggerSet for locking
  [#197](kazu-yamamoto/logger#197. This would have
  performance penalty. So, the major version bumps up. If you see
  performance regression, please register an issue on github.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants