This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 13
package name with @ build error #10
Labels
Comments
kazupon
added
Type: Feature
New feature or request
good first issue
Good for newcomers
labels
Feb 17, 2019
Is there ever a case where a name may contain multiple forward slash characters e.g. |
I have never seen any package like that and in npmjs documentation is not contempled. https://docs.npmjs.com/about-scopes |
True, just wondering if a str.includes would do the job or should we do a recursive search from the index of @ character to the index of the first / character. If a string was containing more than one / the str.includes probably wouldn't work. |
Merged
@kazupon small pr there if you want to try it out. |
kazupon
pushed a commit
that referenced
this issue
Feb 18, 2019
* added stripNamespaceIfExists, updated tests, updated generator/index * clean up
merged #12, and release v0.1.3! |
it si not working 😢 "files" in package.json is ok but build are trying to create scoped package in dist folder |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When I try to build a plugin with package name like:
@something/plugin-name
it will build into folderdist/@something/plugin-name
.Could
@something
be ignored?Thank you very much
The text was updated successfully, but these errors were encountered: