Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

package name with @ build error #10

Closed
d0whc3r opened this issue Feb 16, 2019 · 6 comments
Closed

package name with @ build error #10

d0whc3r opened this issue Feb 16, 2019 · 6 comments
Labels
good first issue Good for newcomers Type: Feature New feature or request

Comments

@d0whc3r
Copy link
Contributor

d0whc3r commented Feb 16, 2019

When I try to build a plugin with package name like: @something/plugin-name it will build into folder dist/@something/plugin-name.
Could @something be ignored?

Thank you very much

@kazupon kazupon added Type: Feature New feature or request good first issue Good for newcomers labels Feb 17, 2019
@EvanBurbidge
Copy link
Contributor

Is there ever a case where a name may contain multiple forward slash characters e.g. @namespace/myPlugin/test ? @d0whc3r

@d0whc3r
Copy link
Contributor Author

d0whc3r commented Feb 18, 2019

I have never seen any package like that and in npmjs documentation is not contempled. https://docs.npmjs.com/about-scopes

@EvanBurbidge
Copy link
Contributor

EvanBurbidge commented Feb 18, 2019

True, just wondering if a str.includes would do the job or should we do a recursive search from the index of @ character to the index of the first / character. If a string was containing more than one / the str.includes probably wouldn't work.

@EvanBurbidge EvanBurbidge mentioned this issue Feb 18, 2019
Merged
@EvanBurbidge
Copy link
Contributor

@kazupon small pr there if you want to try it out.

kazupon pushed a commit that referenced this issue Feb 18, 2019
* added stripNamespaceIfExists, updated tests, updated generator/index

* clean up
@kazupon
Copy link
Owner

kazupon commented Feb 18, 2019

merged #12, and release v0.1.3!

@kazupon kazupon closed this as completed Feb 18, 2019
@d0whc3r
Copy link
Contributor Author

d0whc3r commented Feb 18, 2019

it si not working 😢

"files" in package.json is ok but build are trying to create scoped package in dist folder

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants