Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

#10 #12

Merged
merged 2 commits into from
Feb 18, 2019
Merged

#10 #12

merged 2 commits into from
Feb 18, 2019

Conversation

EvanBurbidge
Copy link
Contributor

PR for the following issue #10

Introduced

  • stripNamespaceIfExists method, checks for the @ symbol and removes namespaces.
  • update generator/index.js to use new method.
  • updated tests to cater for name spaced package names.
  • moved package checking to checkPackageExpectations method.

d0whc3r
d0whc3r reviewed Feb 18, 2019
View reviewed changes
lib/utils.js Show resolved Hide resolved
kazupon
kazupon approved these changes Feb 18, 2019
View reviewed changes
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks!

@kazupon kazupon merged commit 0322146 into kazupon:master Feb 18, 2019
@kazupon kazupon mentioned this pull request Feb 18, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d0whc3r d0whc3r d0whc3r left review comments

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EvanBurbidge @kazupon @d0whc3r