Add interpolation values to missing handler #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry. In CircleCI, occured flow error. |
Codecov Report
@@ Coverage Diff @@
## dev #308 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 9 9
Lines 626 626
=======================================
Hits 602 602
Misses 24 24
Continue to review full report at Codecov.
|
TheAlexLichter
pushed a commit
to TheAlexLichter/vue-i18n
that referenced
this pull request
Mar 10, 2018
…azupon#308) by @sebwas * Correct small typo * Submit formatting values to missing handler * Remove unnecessary & harmful spread operators * Normalize values to be array, adapt test
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To react depending on some kind of "state", the interpolation values should be handed to the missing handler.
To make sure this doesn't break, a test has been added.