Add the path as argument to the custom formatter #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Replace Number and Date format options with standard TS `Intl` types, while also adding guiding TS autocomplete to them. This change exterminates the confusion of which types to follow, while preserving backwards-compatibility for types and adding optional autocomplete.
It's useful to check static variables types whenever possible.
and allow optional formatting
Codecov Report
@@ Coverage Diff @@
## dev #489 +/- ##
==========================================
+ Coverage 96.67% 96.69% +0.01%
==========================================
Files 9 9
Lines 662 665 +3
==========================================
+ Hits 640 643 +3
Misses 22 22
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #489 +/- ##
==========================================
+ Coverage 96.67% 96.69% +0.01%
==========================================
Files 9 9
Lines 662 665 +3
==========================================
+ Hits 640 643 +3
Misses 22 22
Continue to review full report at Codecov.
|
kazupon
requested changes
Dec 20, 2018
decls/i18n.js
Outdated
| @@ -110,5 +110,5 @@ declare interface I18n { | |||
| }; | |||
|
|
|||
| declare interface Formatter { | |||
| interpolate (message: string, values?: any): Array<any> | |||
| interpolate (message: string, values: any, path: string): Array<any> | void | |||
There was a problem hiding this comment.
In the case that interpolate return the nothing, I hope that it's better to be null than undefined.
from undefined to null
kazupon
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #484.
Proposed changes to the API:
Formatter now accepts a third argument: path to the message. This is meant to be used in a case if a custom formatter shall have a specific purpose for the specific keys in a translation object.
If a formatter does not want to work with a specific key - it needs to simply return
undefined.For more details, see proposed API at #484.