Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 bug(index): Fix #515 empty string not returning true #525

Merged
merged 1 commit into from
Mar 3, 2019
Merged

🐛 bug(index): Fix #515 empty string not returning true #525

merged 1 commit into from
Mar 3, 2019

Conversation

kimuraz
Copy link
Contributor

@kimuraz kimuraz commented Mar 2, 2019

Closes #515

@codecov-io
Copy link

Codecov Report

Merging #525 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #525   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files           9        9           
  Lines         683      683           
=======================================
  Hits          660      660           
  Misses         23       23
Impacted Files Coverage Δ
src/index.js 99.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddaad4c...7e888dd. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Mar 2, 2019 •
edited
Loading

Codecov Report

Merging #525 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #525   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files           9        9           
  Lines         683      683           
=======================================
  Hits          660      660           
  Misses         23       23
Impacted Files Coverage Δ
src/index.js 99.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddaad4c...7e888dd. Read the comment docs.

kazupon
kazupon approved these changes Mar 3, 2019
View reviewed changes
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kazupon kazupon merged commit 396c5ca into kazupon:dev Mar 3, 2019
@tt9133github tt9133github mentioned this pull request Sep 18, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimuraz @codecov-io @kazupon