Skip to content
This repository has been archived by the owner on Dec 25, 2017. It is now read-only.

feat(api): fix $validate API when using touched #211

Merged
merged 1 commit into from
Apr 28, 2016
Merged

feat(api): fix $validate API when using touched #211

merged 1 commit into from
Apr 28, 2016

Conversation

losadaem
Copy link
Contributor

Add touched option to willUpdateFlags in RadioValidation and
CheckboxValidation classes.

In 4635ce4 $validate API was updated with touched option. But this
was not implemented in BaseValidation subclasses.

Fixes: #210

@kazupon
Copy link
Owner

kazupon commented Apr 28, 2016

Thank you for your PR!
Can you push the unit tests to repo please ?

Add touched option to `willUpdateFlags` in `RadioValidation` and
`CheckboxValidation` classes.

In 4635ce4 $validate API was updated with touched option. But this
was not implemented in `BaseValidation` subclasses.

Add tests for all validatable elements

Fixes: #210
@losadaem
Copy link
Contributor Author

Done. Let me know if any changes need to be made.

@kazupon kazupon merged commit 68282d1 into kazupon:dev Apr 28, 2016
@kazupon
Copy link
Owner

kazupon commented Apr 28, 2016

Good job! 👍
Thanks!!

@kazupon kazupon removed the in review label Apr 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants